Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include "zip" as required apt dependency in bootstrap error message #14803

Merged
merged 1 commit into from Dec 3, 2020

Conversation

chausner
Copy link
Contributor

@chausner chausner commented Nov 26, 2020

When running bootstrap.sh on a new Ubuntu installation, it currently fails with the message:

Could not find unzip. Please install it (and other dependencies) with:
sudo apt-get install curl unzip tar

The mentioned dependencies are enough to bootstrap vcpkg but when actually installing packages, it turns out that also zip is required:

...
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
-- Building x64-linux-rel
-- Installing: /mnt/d/vcpkg/packages/rtaudio_x64-linux/share/rtaudio/README.md
-- Installing: /mnt/d/vcpkg/packages/rtaudio_x64-linux/share/rtaudio/copyright
-- Performing post-build validation
-- Performing post-build validation done
sh: 1: zip: not found

So I suggest to also include zip in the error message in the bootstrap script.

@PhoebeHui PhoebeHui added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Nov 27, 2020
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Nov 27, 2020
@strega-nil
Copy link
Contributor

strega-nil commented Dec 3, 2020

I think this is a good change; however, it does kinda suck that the error message is sh: 1: zip: not found. I'll open an issue for this error message. If you're interested, we'd love the help!

@strega-nil strega-nil merged commit 8062187 into microsoft:master Dec 3, 2020
@chausner chausner deleted the fix-missing-dep-message branch May 1, 2021 20:47
@ihnorton
Copy link

ihnorton commented Mar 23, 2023

Is zip still required / required on linux? Related (possibly dumb) question: where is it used... I grep'd and I think I only see the usage of tar, but not zip.

[edit]:

Disabled the tool check for zip, and yes it is still required:

-- Performing post-build validation
warning: Failed to compress folder "/root/TileDB/external/vcpkg/packages/liblzma_x64-linux": error: zip failed with exit code: (127).
sh: zip: command not found

the usage comes from here: https://github.com/microsoft/vcpkg-tool/blob/2c5416ae0793584f2baf456ee13182af1cd138b5/src/vcpkg/binarycaching.cpp#L348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants