Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg_apply_patches] Fix Git too long path error #14825

Merged
merged 1 commit into from Dec 15, 2020
Merged

[vcpkg_apply_patches] Fix Git too long path error #14825

merged 1 commit into from Dec 15, 2020

Conversation

Pospelove
Copy link
Contributor

@Pospelove Pospelove commented Nov 28, 2020 •
edited

Fixes #14824

This answer helped me to figure out what's going on.

@Pospelove Pospelove changed the title Fix Git too long path error [mongo-c-driver] Fix Git too long path error Nov 28, 2020
@JackBoosY JackBoosY added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Nov 30, 2020
@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

@strega-nil Could you please check the linux and osx regressions? They are related to the permission.

Thanks.

@ras0219 ras0219 mentioned this pull request Nov 30, 2020
Merged
@strega-nil
Copy link
Contributor

strega-nil commented Nov 30, 2020 •
edited

Rerunning after merging #14848

@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

ras0219
ras0219 suggested changes Nov 30, 2020
View reviewed changes
scripts/cmake/vcpkg_apply_patches.cmake Outdated Show resolved Hide resolved
@Pospelove
Copy link
Contributor Author

kek

@JackBoosY
Copy link
Contributor 

-- Applying patch cmake_dont_build_more_than_needed.patch
CMake Error at scripts/cmake/vcpkg_apply_patches.cmake:63 (message):
  Applying patch failed.  error: unknown switch `c'

@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Dec 8, 2020
@BillyONeal
Copy link
Member

Just pinged @ras0219 / @ras0219-msft again

@BillyONeal
Copy link
Member

I spoke with Robert and he's not a fan of --config local either, I'm investigating a fix that still uses -c.

@BillyONeal
Copy link
Member

Test result:

PS C:\Dev\Users\Denis\AppData\Local\pmm\1.4.2\vcpkg-790910f79f653978f90aadd958abf3c407215552\vcpkg> .\vcpkg.exe install mongo-c-driver
Computing installation plan...
The following packages will be built and installed:
  * libbson[core]:x86-windows -> 1.16.1#2
    mongo-c-driver[core]:x86-windows -> 1.16.1#3
  * zlib[core]:x86-windows -> 1.2.11#9
Additional packages (*) will be modified to complete this operation.
Detecting compiler hash for triplet x86-windows...
Could not locate cached archive: C:\Users\billy\AppData\Local\vcpkg\archives\fb\fb2f04ad0e948f17f46081da042a3c132e598721.zip
Could not locate cached archive: C:\Users\billy\AppData\Local\vcpkg\archives\80\809e8129cb834f39817b645c4f7f20a3bfcd54cc.zip
Could not locate cached archive: C:\Users\billy\AppData\Local\vcpkg\archives\86\86d8ce5e3652d58bcb6075cb1f82df5f84ae6976.zip
Starting package 1/3: libbson:x86-windows
Building package libbson[core]:x86-windows...
-- Downloading https://github.com/mongodb/mongo-c-driver/archive/99d422877c5b5ea52006c13ee3b48297251b2b2d.tar.gz...
-- Extracting source C:/Dev/vcpkg-downloads/mongodb-mongo-c-driver-99d422877c5b5ea52006c13ee3b48297251b2b2d.tar.gz
-- Applying patch fix-uwp.patch
-- Applying patch fix-static-cmake.patch
-- Using source at C:/Dev/Users/Denis/AppData/Local/pmm/1.4.2/vcpkg-790910f79f653978f90aadd958abf3c407215552/vcpkg/buildtrees/libbson/src/97251b2b2d-a3810c39b5.clean
-- Configuring x86-windows-dbg
-- Configuring x86-windows-rel
-- Building x86-windows-dbg
-- Building x86-windows-rel
-- Installing: C:/Dev/Users/Denis/AppData/Local/pmm/1.4.2/vcpkg-790910f79f653978f90aadd958abf3c407215552/vcpkg/packages/libbson_x86-windows/share/libbson/copyright
-- Installing: C:/Dev/Users/Denis/AppData/Local/pmm/1.4.2/vcpkg-790910f79f653978f90aadd958abf3c407215552/vcpkg/packages/libbson_x86-windows/share/libbson/usage
-- Performing post-build validation
-- Performing post-build validation done
Stored binary cache: C:\Users\billy\AppData\Local\vcpkg\archives\fb\fb2f04ad0e948f17f46081da042a3c132e598721.zip
Building package libbson[core]:x86-windows... done
Installing package libbson[core]:x86-windows...
Installing package libbson[core]:x86-windows... done
Elapsed time for package libbson:x86-windows: 17.47 s
Starting package 2/3: zlib:x86-windows
Building package zlib[core]:x86-windows...
-- Using cached C:/Dev/vcpkg-downloads/zlib1211.tar.gz
-- Extracting source C:/Dev/vcpkg-downloads/zlib1211.tar.gz
-- Applying patch cmake_dont_build_more_than_needed.patch
-- Applying patch 0001-Prevent-invalid-inclusions-when-HAVE_-is-set-to-0.patch
-- Applying patch add_debug_postfix_on_mingw.patch
-- Using source at C:/Dev/Users/Denis/AppData/Local/pmm/1.4.2/vcpkg-790910f79f653978f90aadd958abf3c407215552/vcpkg/buildtrees/zlib/src/1.2.11-63309e48e5.clean
-- Configuring x86-windows
-- Building x86-windows-dbg
-- Building x86-windows-rel
-- Using msys root at C:/Dev/vcpkg-downloads/tools/msys2/c809757c94447846
-- Fixing pkgconfig file: C:/Dev/Users/Denis/AppData/Local/pmm/1.4.2/vcpkg-790910f79f653978f90aadd958abf3c407215552/vcpkg/packages/zlib_x86-windows/lib/pkgconfig/zlib.pc
-- Fixing pkgconfig file: C:/Dev/Users/Denis/AppData/Local/pmm/1.4.2/vcpkg-790910f79f653978f90aadd958abf3c407215552/vcpkg/packages/zlib_x86-windows/debug/lib/pkgconfig/zlib.pc
-- Installing: C:/Dev/Users/Denis/AppData/Local/pmm/1.4.2/vcpkg-790910f79f653978f90aadd958abf3c407215552/vcpkg/packages/zlib_x86-windows/share/zlib/copyright
-- Performing post-build validation
-- Performing post-build validation done
Stored binary cache: C:\Users\billy\AppData\Local\vcpkg\archives\80\809e8129cb834f39817b645c4f7f20a3bfcd54cc.zip
Building package zlib[core]:x86-windows... done
Installing package zlib[core]:x86-windows...
Installing package zlib[core]:x86-windows... done
Elapsed time for package zlib:x86-windows: 4.138 s
Starting package 3/3: mongo-c-driver:x86-windows
Building package mongo-c-driver[core]:x86-windows...
-- Using cached C:/Dev/vcpkg-downloads/mongodb-mongo-c-driver-99d422877c5b5ea52006c13ee3b48297251b2b2d.tar.gz
-- Extracting source C:/Dev/vcpkg-downloads/mongodb-mongo-c-driver-99d422877c5b5ea52006c13ee3b48297251b2b2d.tar.gz
-- Applying patch fix-dependency-libbson.patch
-- Applying patch disable-static-when-dynamic-build.patch
-- Applying patch fix-arm-build.patch
-- Using source at C:/Dev/Users/Denis/AppData/Local/pmm/1.4.2/vcpkg-790910f79f653978f90aadd958abf3c407215552/vcpkg/buildtrees/mongo-c-driver/src/97251b2b2d-64741a92bf.clean
-- Configuring x86-windows
-- Building x86-windows-dbg
-- Building x86-windows-rel
-- Installing: C:/Dev/Users/Denis/AppData/Local/pmm/1.4.2/vcpkg-790910f79f653978f90aadd958abf3c407215552/vcpkg/packages/mongo-c-driver_x86-windows/share/mongo-c-driver/copyright
-- Performing post-build validation
-- Performing post-build validation done
Stored binary cache: C:\Users\billy\AppData\Local\vcpkg\archives\86\86d8ce5e3652d58bcb6075cb1f82df5f84ae6976.zip
Building package mongo-c-driver[core]:x86-windows... done
Installing package mongo-c-driver[core]:x86-windows...
Installing package mongo-c-driver[core]:x86-windows... done
Elapsed time for package mongo-c-driver:x86-windows: 14.57 s

Total elapsed time: 38.98 s

The package mongo-c-driver is compatible with built-in CMake targets:

        find_package(libmongoc-1.0 CONFIG REQUIRED)

        target_include_directories(main PRIVATE ${MONGOC_INCLUDE_DIRS})
        target_link_libraries(main PRIVATE ${MONGOC_LIBRARIES})
        target_compile_definitions(main PRIVATE ${MONGOC_DEFINITIONS})

PS C:\Dev\Users\Denis\AppData\Local\pmm\1.4.2\vcpkg-790910f79f653978f90aadd958abf3c407215552\vcpkg>

@JackBoosY JackBoosY removed the info:reviewed Pull Request changes follow basic guidelines label Dec 10, 2020
@Pospelove Pospelove changed the title [mongo-c-driver] Fix Git too long path error [[vcpkg_apply_patches]] Fix Git too long path error Dec 10, 2020
@Pospelove Pospelove changed the title [[vcpkg_apply_patches]] Fix Git too long path error [vcpkg_apply_patches] Fix Git too long path error Dec 10, 2020
@Pospelove
Copy link
Contributor Author

🆘

@JackBoosY
Copy link
Contributor

JackBoosY commented Dec 15, 2020 •
edited 

cl : Command line warning D9025 : overriding '/Z7' with '/Zi'
jmemansi.c(234): fatal error C1051: program database file, 'D:\buildtrees\gdal\x64-windows-dbg\gdal301_d.pdb', has an obsolete format, delete it and recompile

Should be a baseline issue.

@JackBoosY
Copy link
Contributor

LGTM.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Dec 15, 2020
@BillyONeal BillyONeal merged commit f78ccd9 into microsoft:master Dec 15, 2020
@BillyONeal
Copy link
Member

thanks for your help!

@Pospelove Pospelove deleted the patch-1 branch December 16, 2020 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219 ras0219 ras0219 requested changes

@ras0219-msft ras0219-msft ras0219-msft approved these changes

@JackBoosY JackBoosY Awaiting requested review from JackBoosY

@strega-nil strega-nil Awaiting requested review from strega-nil

Assignees

@JackBoosY JackBoosY

Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[mongo-c-driver] build failure
6 participants
@Pospelove @JackBoosY @strega-nil @BillyONeal @ras0219 @ras0219-msft