New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opencascade] Fix static build #14901
Conversation
@fauder Can you test this PR? Thanks. |
Thank you for taking the time to fix this. What I did:
Build failed unfortunately:
|
Pulled f58bacb and tried again and got errors:
|
@fauder I will ping you when I finish this PR. |
Sure. |
@fauder Ready |
#include <stdlib.h> | ||
|
||
- #ifdef _MSC_VER | ||
- #pragma comment (lib, "freetype.lib") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already set to link in cmake.
It builds without any errors on a fresh vcpkg clone 👍 I'll wait for it to be merged to try it on my actual vcpkg directory. It took 40 minutes sheesh. Thanks a lot by the way. |
Thanks for your help! |
Fixes #14874.
Already tested all features in
x64-windows
andx64-windows-static
successfully.