Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-sdk-cpp] Add find_dependency to AWSSDKConfig.cmake and fix usage #14936

Merged
merged 1 commit into from Dec 5, 2020
Merged

[aws-sdk-cpp] Add find_dependency to AWSSDKConfig.cmake and fix usage #14936

merged 1 commit into from Dec 5, 2020

Conversation

JackBoosY
Copy link
Contributor

  • The AWSSDKConfig.cmake dependency provided by the upstream lacks find_dependency. Add it.
  • AWSSDKConfig.cmake should be used as the main entry point.

Fixes #7373 (comment)

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Dec 4, 2020
@JackBoosY JackBoosY mentioned this pull request Dec 4, 2020
Closed
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Dec 4, 2020
@BillyONeal BillyONeal merged commit 87a908d into microsoft:master Dec 5, 2020
@BillyONeal
Copy link
Member

Thanks!

@JackBoosY JackBoosY deleted the dev/jack/aws-sdk-cpp-find-dependency branch December 7, 2020 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[curl] x64-linux debug build links against release version of the lib
3 participants
@JackBoosY @BillyONeal @NancyLi1013