Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gamenetworkingsockets] Add new port #14937

Merged
merged 7 commits into from Jan 25, 2021

Conversation

Balnian
Copy link
Contributor

@Balnian Balnian commented Dec 4, 2020

Describe the pull request

Adds a port for Valve's GameNetworkingSockets

  • What does your PR fix? Fixes #

Adds a port for GameNetworkingSockets
(finishing @aiusepsi great original PR #13312)

  • Which triplets are supported/not supported? Have you updated the CI baseline?

x64-windows and x86-windows are supported
arm64-windows, arm-uwp-static, x64-uwp, and x64-windows-static are not supported

It should?

@PhoebeHui PhoebeHui added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Dec 4, 2020
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

ports/gamenetworkingsockets/vcpkg.json Outdated Show resolved Hide resolved
ports/gamenetworkingsockets/portfile.cmake Outdated Show resolved Hide resolved
@BillyONeal
Copy link
Member

This port is trying to use features to express alternatives -- the libsodium vs. openssl backends. Unfortunately using features to express this is inappropriate; the "north star" for features is that if port[featureA] and port[featureB] install correctly, installing port[featureA,featureB] needs to also work, but you have them paving over each other here.

As a result you'll need to choose one of the backends for this port as expressed in vcpkg. You can leave a comment for which changes would be necessary if someone wants to create an overlay-port that uses libsodium instead.

@BillyONeal
Copy link
Member

This port triggered a team discussion because we have applied this "no feature alternatives" policy inconsistently depending on which maintainer was reviewing a given thing. The updates to docs are being done in #15171

@Balnian
Copy link
Contributor Author

Balnian commented Jan 5, 2021

Sorry for the radio silence.
With what @BillyONeal said, that kind of helped me made the decision to drop the support for libsodium and refactor the port to only use OpenSSL as a dependency.

aiusepsi and others added 6 commits January 23, 2021 15:33
* added `vcpkg_check_linkage(ONLY_DYNAMIC_LIBRARY)`
* added missing trailing newline
* removed all entries in ci.baseline.txt

Adding license field in manifest

Updated library version
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Balnian, thanks for your updates!

@PhoebeHui PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 25, 2021
@dan-shaw dan-shaw merged commit 051b33d into microsoft:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants