New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gamenetworkingsockets] Add new port #14937
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
This port is trying to use features to express alternatives -- the libsodium vs. openssl backends. Unfortunately using features to express this is inappropriate; the "north star" for features is that if As a result you'll need to choose one of the backends for this port as expressed in vcpkg. You can leave a comment for which changes would be necessary if someone wants to create an overlay-port that uses libsodium instead. |
This port triggered a team discussion because we have applied this "no feature alternatives" policy inconsistently depending on which maintainer was reviewing a given thing. The updates to docs are being done in #15171 |
Sorry for the radio silence. |
* added `vcpkg_check_linkage(ONLY_DYNAMIC_LIBRARY)` * added missing trailing newline * removed all entries in ci.baseline.txt Adding license field in manifest Updated library version
197f47c
to
fccfd53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Balnian, thanks for your updates!
Describe the pull request
Adds a port for Valve's GameNetworkingSockets
Adds a port for GameNetworkingSockets
(finishing @aiusepsi great original PR #13312)
x64-windows and x86-windows are supported
arm64-windows, arm-uwp-static, x64-uwp, and x64-windows-static are not supported
It should?