Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ATK] Installing .pc files #14972

Merged
merged 5 commits into from
Dec 7, 2020
Merged

[ATK] Installing .pc files #14972

merged 5 commits into from
Dec 7, 2020

Conversation

faserg1
Copy link
Contributor

@faserg1 faserg1 commented Dec 6, 2020

Prepare and install atk.pc file.
This pull request is a part of #9564 solution.

@ghost
Copy link

ghost commented Dec 6, 2020

CLA assistant check
All CLA requirements met.

@JackBoosY JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Dec 7, 2020
ports/atk/portfile.cmake Outdated Show resolved Hide resolved
ports/atk/portfile.cmake Outdated Show resolved Hide resolved
@JackBoosY JackBoosY changed the title Installing .pc files for ATK port [ATK] Installing .pc files Dec 7, 2020
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the port version. See documentation.

@faserg1
Copy link
Contributor Author

faserg1 commented Dec 7, 2020

ATK compiles. Now failed GTK for some reason. Very strange.

@JackBoosY
Copy link
Contributor

CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
ATK_LIBRARY
    linked by target "gtk-3" in directory D:/buildtrees/gtk/src/gtk+-3-b723a7b846.clean
    linked by target "gdk-3" in directory D:/buildtrees/gtk/src/gtk+-3-b723a7b846.clean
    linked by target "gailutil-3" in directory D:/buildtrees/gtk/src/gtk+-3-b723a7b846.clean

CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_INSTALL_BINDIR
    CMAKE_INSTALL_LIBDIR


CMake Generate step failed.  Build files cannot be regenerated correctly.

It seems that because you fixed ATK's pkgconfig, gtk uses the pkgconfig internally to find atk, resulting this error.

@faserg1
Copy link
Contributor Author

faserg1 commented Dec 7, 2020

@JackBoosY Should I bump port-version for gtk if I update CMakeLists.txt in GTK port folder? There was used old 1.0 version

@JackBoosY
Copy link
Contributor

@faserg1 No, since this is an error using atk's pkgconfig, I think you should fix pkgconfig.

@faserg1
Copy link
Contributor Author

faserg1 commented Dec 7, 2020

@JackBoosY I just do not understand, why in CMakeLists.txt and portfile version is 1.0:

set(ATK_LIB_SUFFIX 1.0)

if used sources of >2
set(ATK_VERSION 2.24.0)

Again, I can modify this line:
set(ATK_LIB_SUFFIX 1.0)

to ver2
Or return everything back, like there is ATK ver1

@JackBoosY
Copy link
Contributor

Seems that never changes since atk was added to vcpkg, see log.

@faserg1
Copy link
Contributor Author

faserg1 commented Dec 7, 2020

@JackBoosY So leave it as is? Ver1, right?

@JackBoosY
Copy link
Contributor

@faserg1 I think your changes is right.

@faserg1
Copy link
Contributor Author

faserg1 commented Dec 7, 2020

@JackBoosY So if update to ver2 I need to patch gtk CMakeFiles.txt

set(ATK_LIB_SUFFIX 1.0)

That what I am talking about =)

@JackBoosY
Copy link
Contributor

@faserg1 Yep, you're right, I think that's the reason why this regression happened!

@faserg1
Copy link
Contributor Author

faserg1 commented Dec 7, 2020

@JackBoosY Ah, no, there is API version of atk, it's ver1. So I need just return back. It's so confusing...
If just look at atk source (atk.pc.in), there will be ver1.

Cflags: -I${includedir}/atk-1.0

@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Dec 7, 2020
@BillyONeal BillyONeal merged commit 08b3a43 into microsoft:master Dec 7, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants