-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ATK] Installing .pc files #14972
[ATK] Installing .pc files #14972
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please bump the port version. See documentation.
ATK compiles. Now failed GTK for some reason. Very strange. |
It seems that because you fixed ATK's pkgconfig, gtk uses the pkgconfig internally to find atk, resulting this error. |
@JackBoosY Should I bump port-version for gtk if I update CMakeLists.txt in GTK port folder? There was used old 1.0 version |
@faserg1 No, since this is an error using atk's pkgconfig, I think you should fix pkgconfig. |
@JackBoosY I just do not understand, why in CMakeLists.txt and portfile version is 1.0: vcpkg/ports/atk/CMakeLists.txt Line 4 in c303dd0
if used sources of >2 vcpkg/ports/atk/portfile.cmake Line 3 in c303dd0
Again, I can modify this line: vcpkg/ports/gtk/CMakeLists.txt Line 9 in c303dd0
to ver2 Or return everything back, like there is ATK ver1 |
Seems that never changes since atk was added to vcpkg, see log. |
@JackBoosY So leave it as is? Ver1, right? |
@faserg1 I think your changes is right. |
@JackBoosY So if update to ver2 I need to patch gtk CMakeFiles.txt vcpkg/ports/gtk/CMakeLists.txt Line 9 in c303dd0
That what I am talking about =) |
@faserg1 Yep, you're right, I think that's the reason why this regression happened! |
@JackBoosY Ah, no, there is API version of atk, it's ver1. So I need just return back. It's so confusing...
|
Thanks for your contribution! |
Prepare and install atk.pc file.
This pull request is a part of #9564 solution.