Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[seal] Update to SEAL 3.6.1 #15015

Merged
merged 1 commit into from Jan 28, 2021
Merged

Conversation

kiromaru
Copy link
Contributor

@kiromaru kiromaru commented Dec 9, 2020

Update SEAL port to version 3.6.1

  • What does your PR fix? Updating to a new SEAL version

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    Tested x64-windows-static, x64-linux, x64-osx
    x64-windows/x86-windows are not supported as the library only supports static linkage in Windows.

  • Does your PR follow the maintainer guide?
    Yes

@JonLiu1993 JonLiu1993 self-assigned this Dec 9, 2020
ports/seal/CONTROL Show resolved Hide resolved
@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision requires:author-response and removed requires:author-response labels Dec 9, 2020
@JonLiu1993 JonLiu1993 added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Dec 10, 2020
@JonLiu1993
Copy link
Member

@kiromaru ,The feature test on windows is successful, but there seems to be a problem with x64-linux on linux, can you take a look?

home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/util/gcc.h:10:19: error: SEAL requires __GNUC__ >= 6
 #pragma GCC error "SEAL requires __GNUC__ >= 6"
                   ^
In file included from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/memorymanager.h:6:0,
                 from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/encryptionparams.h:6,
                 from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/context.h:6,
                 from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/ciphertext.h:6,
                 from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/ciphertext.cpp:4:
/home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/util/defines.h:120:28: error: ‘byte’ in namespace ‘std’ does not name a type
     using seal_byte = std::byte;
                            ^
In file included from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/util/globals.h:6:0,
                 from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/memorymanager.h:7,
/home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/util/common.h: In function ‘constexpr T seal::util::mul_safe(T, T)’:
/home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/util/defines.h:133:30: error: expected ‘(’ before ‘constexpr’
 #define SEAL_IF_CONSTEXPR if constexpr
                              ^
/home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/util/common.h:140:13: note: in expansion of macro ‘SEAL_IF_CONSTEXPR’
             SEAL_IF_CONSTEXPR(std::is_unsigned<T>::value)
             ^
/home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/ciphertext.cpp:347:1: error: expected ‘}’ at end of input
 } // namespace seal
 ^
/home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/ciphertext.cpp: At global scope:
/home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/ciphertext.cpp:347:1: error: expected ‘}’ at end of input
/home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/ciphertext.cpp:347:1: error: expected ‘}’ at end of input
[2/40] /usr/bin/c++  -I/home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src -Inative/src -isystem /home/vzhli17/Jon/test2/vcpkg/installed/x64-linux/include -fPIC -Wall -Wextra -Wconversion -Wshadow -pedantic -g -fPIC -pthread -std=gnu++1z -MD -MT CMakeFiles/seal.dir/native/src/seal/context.cpp.o -MF CMakeFiles/seal.dir/native/src/seal/context.cpp.o.d -o CMakeFiles/seal.dir/native/src/seal/context.cpp.o -c /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/context.cpp
FAILED: CMakeFiles/seal.dir/native/src/seal/context.cpp.o
/usr/bin/c++  -I/home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src -Inative/src -isystem /home/vzhli17/Jon/test2/vcpkg/installed/x64-linux/include -fPIC -Wall -Wextra -Wconversion -Wshadow -pedantic -g -fPIC -pthread -std=gnu++1z -MD -MT CMakeFiles/seal.dir/native/src/seal/context.cpp.o -MF CMakeFiles/seal.dir/native/src/seal/context.cpp.o.d -o CMakeFiles/seal.dir/native/src/seal/context.cpp.o -c /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/context.cpp
In file included from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/util/defines.h:106:0,
                 from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/memorymanager.h:6,
                 from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/encryptionparams.h:6,
                 from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/context.h:6,
                 from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/context.cpp:4:
/home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/util/gcc.h:10:19: error: SEAL requires __GNUC__ >= 6
 #pragma GCC error "SEAL requires __GNUC__ >= 6"
                   ^
In file included from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/memorymanager.h:6:0,
                 from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/encryptionparams.h:6,
                 from /home/vzhli17/Jon/test2/vcpkg/buildtrees/seal/src/d394eb2aeb-d50aefddbc.clean/native/src/seal/context.h:6,

@kiromaru
Copy link
Contributor Author

Hi JonLiu1993,
SEAL requires at least GCC 7, that is the cause of the error. Notice that the PR pipeline was able to build x64-linux without problems. I tested it locally as well.

@JonLiu1993 JonLiu1993 removed the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Dec 11, 2020
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jan 28, 2021
@dan-shaw dan-shaw merged commit 5546681 into microsoft:master Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants