Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sentry-native] Fix sentry-config-cmake.in #15042

Merged
merged 1 commit into from
Dec 12, 2020
Merged

[sentry-native] Fix sentry-config-cmake.in #15042

merged 1 commit into from
Dec 12, 2020

Conversation

JackBoosY
Copy link
Contributor

  • In *-config.cmake, we should use find_dependency instead of find_package.
  • Fix curl target name.

Fixes #15023.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Dec 10, 2020
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Dec 10, 2020
@JackBoosY
Copy link
Contributor Author

@korrix Can you please test this PR?

Thanks.

@BillyONeal BillyONeal merged commit a9df4e2 into microsoft:master Dec 12, 2020
@BillyONeal
Copy link
Member

image

@JackBoosY JackBoosY deleted the dev/jack/15023 branch December 14, 2020 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[sentry-native] build failure / problem with curl dependency
3 participants
@JackBoosY @BillyONeal @NancyLi1013