[vcpkg_from_git] new options TAG and X_OUT_REF #15049
Conversation
- TAG github tag to checkout - OUT_REF github commit id related to tag or ref (useable for automatic updates of ports if used with a version tag)
|
We explicitly ask for REFs and not tags in the shared helpers in order to defend against tag republishing. If this functionality is just for qt6 updates, it seems more appropriate to keep private to the qt ports. |
|
@ras0219-msft: I hope qt is stable enough to not do that. This PR does not change the behavior it still requires REF. It just checks out by TAG if available and compare the result against the given REF. So tag republishing will still be detected. If a port is doing tag republishing regularly the port simply needs to be updated to remove the TAG option without any other changes. |
JackBoosY
added
category:tool-update
|
Thanks for the explanation; I didn't read the code closely enough. I can potentially see use in the TAG field as an additional check on top of the REF field. Could you link to exactly how you've used OUT_REF? |
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Neumann-A
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Should be good now. |
| @@ -41,7 +48,7 @@ Relative paths are based on the port directory. | |||
| include(vcpkg_execute_in_download_mode) | |||
|
|
|||
| function(vcpkg_from_git) | |||
| set(oneValueArgs OUT_SOURCE_PATH URL REF) | |||
| set(oneValueArgs OUT_SOURCE_PATH URL REF TAG X_OUT_REF) | |||
There was a problem hiding this comment.
@BillyONeal please remind me.
As this is internal and documented should it be prefixed with X_ or Z_?
(useable for automatic updates of ports if used with a version tag)
I use this in my two Qt PRs to directly checkout from
code.qt.ioand enable automatic updates of the refs on tag change