Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flatbuffers] Fix to working with vcpkg gRPC #15079

Closed
wants to merge 1 commit into from

Conversation

youknowone
Copy link
Contributor

@youknowone youknowone commented Dec 12, 2020

What does your PR fix?

The last flatbuffers release working with gRPC 1.14 but not with current version. Because vcpkg only support the lastest version, flatbuffers+gRPC use case is now not working with vcpkg.

This patch temporary fix flatbuffers working with the latest gRPC.
When the next flatbuffers version is released with latest gRPC support, this patch can be removed.

Which triplets are supported/not supported? Have you updated the CI baseline?

Not changed

Does your PR follow the maintainer guide?

The last flatbuffers release working with gRPC 1.14 but not with current
version. Because vcpkg only support the lastest version, flatbuffers+gRPC
use case is now not working with vcpkg.

This patch fix flatbuffers working with the latest gRPC.
When the next flatbuffers version is released with latest gRPC support,
this patch can be removed.
@BillyONeal
Copy link
Member

Is upstream doing this and/or have they indicated support for it?

@youknowone
Copy link
Contributor Author

I found this is an opened issue for the upstream. google/flatbuffers#5836

Actually I am not sure what will be the best fix for vcpkg. By the issue, gRPC and flatbuffers have conflict requirement, so this will be unlikely to be solved in short time.

If vcpkg flatbuffers can use gRPC 1.16.1, it will be solved but vcpkg only support single latest version. What will be the best solution for this problem?

@NancyLi1013 NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Dec 14, 2020
@NancyLi1013
Copy link
Contributor

Hi @youknowone

Thanks for your PR.

GRPC has been updated to 1.33.1 in vcpkg. It's impossible to downgrade it to 1.16. I also noticed that there were some discussions about the support between flatbuffers + grpc in grpc upstream grpc/grpc#20594.

So it might need more time to implement this feature on both flatbuffers and grpc sides.

For vcpkg, we recommend to use the changes or feature from upstream.

If you want to support this feature in vcpkg, you can make a pull request to flatbuffers or grpc upstream.

@NancyLi1013 NancyLi1013 added the depends:upstream-changes Waiting on a change to the upstream project label Dec 14, 2020
@youknowone
Copy link
Contributor Author

Thank you for the review

@youknowone youknowone closed this Dec 16, 2020
@youknowone youknowone deleted the grpc-flatbuffers branch December 16, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist depends:upstream-changes Waiting on a change to the upstream project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants