Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid C4819 warning during bootstrap-vcpkg.bat #15095

Merged
merged 2 commits into from Dec 14, 2020

Conversation

tetsuh
Copy link
Contributor

@tetsuh tetsuh commented Dec 13, 2020

Comment-only modification but fixes #15093 .

The C4819 warnings are introduced by UTF-8 characters in the comments.
So, I converted UTF-8 characters into Laten-1 ASCII characters.

Comment-only modification but this fix microsoft#15093 .

The C4819 warnings are introduced by UTF-8 characters in the comments.
So, I converted UTF-8 characters into Laten-1 ASCII characters.
@tetsuh tetsuh marked this pull request as ready for review December 13, 2020 16:56
@tetsuh tetsuh marked this pull request as draft December 13, 2020 17:01
@JackBoosY JackBoosY added the category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) label Dec 14, 2020
@JackBoosY JackBoosY marked this pull request as ready for review December 14, 2020 03:00
@JackBoosY
Copy link
Contributor

LGTM.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Dec 14, 2020
@BillyONeal BillyONeal merged commit 43e0f1b into microsoft:master Dec 14, 2020
@BillyONeal
Copy link
Member

Thanks!

@tetsuh
Copy link
Contributor Author

tetsuh commented Dec 15, 2020

Approved and merged within a day !
I'm happy such quick contribution. Thanks !

ryukw7 pushed a commit to ryukw7/vcpkg that referenced this pull request Dec 15, 2020
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C4819 warning during bootstrap-vcpkg.bat
3 participants