Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[coin] x64-windows-statid-md fixes #15125

Merged
merged 3 commits into from Dec 17, 2020
Merged

Conversation

ankurvdev
Copy link
Contributor

Fix the coin port to build with x64-windows-static-md

  • What does your PR fix? Fixes #

  • Which triplets are supported/not supported? Have you updated the CI baseline?

  • Does your PR follow the maintainer guide?

@JonLiu1993 JonLiu1993 added the category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. label Dec 15, 2020
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the port version. See documentation.

@ankurvdev
Copy link
Contributor Author

Please bump the port version. See documentation.

Done. Please review and merge

@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines category:port-bug The issue is with a library, which is something the port should already support and removed requires:author-response labels Dec 16, 2020
@BillyONeal BillyONeal merged commit 43ed421 into microsoft:master Dec 17, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

ryukw7 pushed a commit to ryukw7/vcpkg that referenced this pull request Dec 24, 2020
@ankurvdev ankurvdev deleted the ankurv/coin branch December 25, 2020 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants