Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[poppler] Add new port #15158
[poppler] Add new port #15158
Changes from 24 commits
88b3ec7
6cd4f47
faae10e
4b48605
2259aec
62ffdb6
0af72fb
c90c08b
b28b19b
24e8c31
746da5b
adbb21c
2277082
5f133ea
27742d5
ffffde3
f4ca0d3
d37d64d
965ed9d
25fbdfd
8f40e7e
4272c89
4bc4f5e
198df3a
869b4ba
190b659
be3d0bd
eca260a
a994404
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see any places used
devil
in source codes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but without
devil
it failed to pass checks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to figure out where and how it is used in this port.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked the
include
files, nodevil
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like an optional dependency.
https://github.com/freedesktop/poppler/blob/master/CMakeLists.txt#L132
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WITH_FONTCONFIGURATION_FONTCONFIG
is true when while"platform": "!(windows | android)"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also an optional dependency.
iconv
is only required in cpp module, which might be considered to add a feature.https://github.com/freedesktop/poppler/blob/master/CMakeLists.txt#L230
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For C++
ENABLE_CPP
is always true.