Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qt5-base] mysql plugin added #15170

Merged
merged 8 commits into from Jan 12, 2021
Merged

[qt5-base] mysql plugin added #15170

merged 8 commits into from Jan 12, 2021

Conversation

jepessen
Copy link
Contributor

The pull request creates the qsqlmysql database plugin for qt5-base.

It adds a dependency from libmysql in order to build it before the plugin since it's requested.

@JackBoosY JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Dec 17, 2020
@jepessen
Copy link
Contributor Author

Hi.
It's possible in some way to see the error logs written during the tests, like this one?

Because I can try to fix for all configuration that I have, I can't test every of them (I don't have linux machines or osx for example) so I cannot perform local tests and I cannot check what's wrong with them.

@JackBoosY
Copy link
Contributor

@jepessen

  1. Click Details in pipeline test results below.
  2. Click View more details on Azure Pipelines
  3. Click [NUM] artifacts produced
  4. Click the three vertical dots on the far right of the error log entry
  5. Click Download artifacts

@jepessen
Copy link
Contributor Author

@JackBoosY ok thanks a lot

@JackBoosY
Copy link
Contributor

cc @Neumann-A for review this PR.

@JackBoosY
Copy link
Contributor

@Neumann-A said this should be added as a qt5-base feature.

@jepessen
Copy link
Contributor Author

Ok I'll add it as feature ASAP.

@jepessen
Copy link
Contributor Author

I've set the mysql plugin as qt5-base feature.

ports/qt5-base/portfile.cmake Outdated Show resolved Hide resolved
@JackBoosY
Copy link
Contributor

LGTM.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Dec 29, 2020
@JackBoosY JackBoosY added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Dec 30, 2020
@jepessen
Copy link
Contributor Author

jepessen commented Jan 2, 2021

I think it should be there, because there's already sqlite and postgresql. Since they are all plugin, or we put them all together at once or none of them in my opinion. There's no reason to include postgresql plugin by default and not mysql, or vice versa. Since postgresql plugin is already installed by default with qt5 I've followed the same logic (it was the reason why I did't added it with a separate feature at start).

@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 5, 2021
@dan-shaw dan-shaw merged commit a8f5147 into microsoft:master Jan 12, 2021
@JackBoosY
Copy link
Contributor

No...no... the mysql doesn't support x86 now, so if you try to install qt5 directly, it will shows us:

CMake Error at scripts/cmake/vcpkg_fail_port_install.cmake:97 (message):
  Architecture 'x86' not supported by libmysql!

I will open a PR to remove the default feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants