Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ctp] bugfix for linux-x64 and file name case sensitivity #15183

Merged
merged 3 commits into from Dec 23, 2020
Merged

[ctp] bugfix for linux-x64 and file name case sensitivity #15183

merged 3 commits into from Dec 23, 2020

Conversation

xgao1023
Copy link
Contributor

[ctp] Bugfix for Linux build

  • fix the issue of Linux installation due to wrong archive file name; fix the debug folder name (Debug -> debug)

NancyLi1013
NancyLi1013 reviewed Dec 18, 2020
View reviewed changes
Copy link
Contributor

@NancyLi1013 NancyLi1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also bump the version in CONTROL file? Add Port-Version: 1

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support requires:author-response labels Dec 18, 2020
@xgao1023
Copy link
Contributor Author

Could you please also bump the version in CONTROL file? Add Port-Version: 1

Done in commit 68d364b

@NancyLi1013
Copy link
Contributor

@xgao1023

Have you tested feature datacollect?

@NancyLi1013 NancyLi1013 added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Dec 21, 2020
@NancyLi1013
Copy link
Contributor

Feature has passed with the following triplets:

  • x86-windows
  • x64-windows
  • x64-linux

Note: ctp only supports dynamic build.

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Dec 22, 2020
@BillyONeal BillyONeal merged commit 70caed7 into microsoft:master Dec 23, 2020
@BillyONeal
Copy link
Member

Thanks for the fix!

ryukw7 pushed a commit to ryukw7/vcpkg that referenced this pull request Dec 24, 2020
@xgao1023
[ctp] bugfix for linux-x64 and file name case sensitivity (microsoft#…
49ee8bd 
…15183)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xgao1023 @NancyLi1013 @BillyONeal