Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed port of quirc - patch did no longer apply / modified to fix build #15252

Merged
merged 6 commits into from Dec 29, 2020

Conversation

Markus87
Copy link
Contributor

  • Quirc did no longer build for any triplet because the patch was for a previous version of quirc
  • Modified the patch to get the windows triplets working again with the new version of quirc

@Markus87
Copy link
Contributor Author

I dont know how this did not break any tests.
Are not all ports tested by CI? If so how to get a port into the automatic tests?

@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Dec 23, 2020
@JackBoosY
Copy link
Contributor

@Markus87 Maybe the original error has been fixed by other means, and the patch is no longer needed.
So does this PR still exist?

@Markus87
Copy link
Contributor Author

@JackBoosY Indeed the original patch would no longer be needed, but a new patch is required to make it build with msvc.
I just checked the latest code in the quirc repository and it seems fixed there, so updating quirc to the latest version should make the patch obsolete.

I will try to update quirc to the latest version. If that works can I use this pull request for updating the port or should I start a new one?

@JackBoosY
Copy link
Contributor

@Markus87 Both patch or update are fine.

@JackBoosY JackBoosY added category:port-update The issue is with a library, which is requesting update new revision and removed category:port-bug The issue is with a library, which is something the port should already support labels Dec 24, 2020
@JackBoosY
Copy link
Contributor

CMake Error at ports/quirc/portfile.cmake:24 (file):
  file COPY cannot find
  "/mnt/vcpkg-ci/buildtrees/quirc/src/b114181c40-f1e71e0d5b.clean/license":
  No such file or directory.
Call Stack (most recent call first):
  scripts/ports.cmake:136 (include)

Will fix later.

@JackBoosY
Copy link
Contributor

LGTM.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Dec 29, 2020
@vicroms vicroms merged commit 3ddbba7 into microsoft:master Dec 29, 2020
@vicroms
Copy link
Member

vicroms commented Dec 29, 2020

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants