New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed port of quirc - patch did no longer apply / modified to fix build #15252
Conversation
Markus87
commented
Dec 22, 2020
- Quirc did no longer build for any triplet because the patch was for a previous version of quirc
- Modified the patch to get the windows triplets working again with the new version of quirc
I dont know how this did not break any tests. |
@Markus87 Maybe the original error has been fixed by other means, and the patch is no longer needed. |
@JackBoosY Indeed the original patch would no longer be needed, but a new patch is required to make it build with msvc. I will try to update quirc to the latest version. If that works can I use this pull request for updating the port or should I start a new one? |
@Markus87 Both patch or update are fine. |
Will fix later. |
LGTM. |
Thanks for the PR! |