New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[boost-modular-builder] let fallback to default tool path #15254
[boost-modular-builder] let fallback to default tool path #15254
Conversation
@xandox, could you open an issue for this? |
@PhoebeHui sure but for what concrete? |
@xandox, I'm also not sure if it's a correct fix, since it affects a community triplet, this is not usual scenario we're working on, but we accept the PRs for fixing the issue, I suggest to open an issue with details so others may replicate this problem. BTW, what does the issue have to do with manifest? this is not be a problem if not in manifest mode? |
Tried to explain everything in #15291 |
@xandox, could you please resolve the conflicts? @BillyONeal, could you help further review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks OK to me.
# Conflicts: # ports/boost-modular-build-helper/CONTROL
Let fallback to default boost build path.
This fix works for me now but I am not sure it is correct way to fix a problem.
I use vcpkg in manifest mode and try cross compile my project for android. I redefine
VCPKG_TARGET_ARCHITECTURE
andVCPKG_CMAKE_SYSTEM_NAME
forboost-build
port in overplayed triplet file, but any checks in this script assumes that you use vcpkg not in manifest mode. Maybe it's better to check here if we in manifest mode but there are not any cmake variable which can helps to detect this mode (VCPKG_MANIFEST_MODE not defined, VCPKG_MANIFEST_INSTALL is OFF).What does your PR fix? Fixes #
Which triplets are supported/not supported? Have you updated the CI baseline?
Does your PR follow the maintainer guide?