Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testing with VS2015 and VS2017 compilers. #15257

Merged
merged 3 commits into from
Dec 29, 2020
Merged

Add testing with VS2015 and VS2017 compilers. #15257

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39b2b8b
Add testing with VS2015 and VS2017 compilers.
BillyONeal Dec 23, 2020
8df5ba4
Apply Nicole CRs.
BillyONeal Dec 23, 2020
a163fde
Merge remote-tracking branch 'origin/master' into vs_old_versions
BillyONeal Dec 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion scripts/azure-pipelines/windows/azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- script: .\bootstrap-vcpkg.bat
displayName: 'Build vcpkg'
- task: CmdLine@2
displayName: "Build vcpkg with CMake and Run Tests"
displayName: "Build vcpkg with CMake, with older VS, and Run Tests"
condition: eq('${{ parameters.triplet }}', 'x86-windows')
inputs:
script: |
Expand All @@ -39,6 +39,10 @@ jobs:
cmake.exe -G Ninja -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DVCPKG_DEVELOPMENT_WARNINGS=ON -DVCPKG_WARNINGS_AS_ERRORS=ON -DVCPKG_BUILD_FUZZING=ON -B build.x86.debug -S toolsrc
ninja.exe -C build.x86.debug
build.x86.debug\vcpkg-test.exe
cmake -G "Visual Studio 16 2019" -A Win32 -T v140 -DBUILD_TESTING=OFF -DVCPKG_DEVELOPMENT_WARNINGS=OFF -DVCPKG_WARNINGS_AS_ERRORS=ON -DVCPKG_BUILD_FUZZING=OFF -B build.x86.vs2015 -S toolsrc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we possibly want to build without warnings as errors in older VS versions, since we will be building with them as errors in the newer version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicole asked for warnings as errors everywhere and it didn't bother me enough to mess with it. I'd prefer to get this validation in and that switch can be changed later when the whole team is in the office to argue about it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be warnings in older compilers that don't exist in later versions; I want to make sure we catch those warnings.

cmake --build build.x86.vs2015
cmake -G "Visual Studio 16 2019" -A Win32 -T v141 -DBUILD_TESTING=OFF -DVCPKG_DEVELOPMENT_WARNINGS=OFF -DVCPKG_WARNINGS_AS_ERRORS=ON -DVCPKG_BUILD_FUZZING=OFF -B build.x86.vs2017 -S toolsrc
cmake --build build.x86.vs2017
failOnStderr: true
- task: PowerShell@2
displayName: 'Run vcpkg end-to-end tests'
Expand Down