Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libsodium] use x64 specific gcc options only on x64 platform #15269

Merged
merged 1 commit into from Dec 28, 2020
Merged

[libsodium] use x64 specific gcc options only on x64 platform #15269

merged 1 commit into from Dec 28, 2020

Conversation

isanych
Copy link
Contributor

@isanych isanych commented Dec 23, 2020 •
edited

fixes #15288

@isanych isanych changed the title [libsodium] do use x64 specific gcc options only on x64 platform [libsodium] do not use x64 specific gcc options only on x64 platform Dec 23, 2020
@isanych isanych force-pushed the libsodium_on_arm branch 2 times, most recently from f219e19 to f5200c3 Compare December 23, 2020 15:19
@isanych isanych changed the title [libsodium] do not use x64 specific gcc options only on x64 platform [libsodium] use x64 specific gcc options only on x64 platform Dec 23, 2020
@PhoebeHui PhoebeHui added the category:port-bug The issue is with a library, which is something the port should already support label Dec 24, 2020
PhoebeHui
PhoebeHui requested changes Dec 24, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isanych, thanks for your contribution!

Could you update the version in CONTROL file
From
Version: 1.0.18-2
To
Version: 1.0.18
Port-Version: 3

Could you also open an issue so others may replicate this problem?

@PhoebeHui
Copy link
Contributor

cc @myd7349 who may interest in the changes.

@BillyONeal, could you help further review?

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Dec 25, 2020
@BillyONeal BillyONeal merged commit 77c59a8 into microsoft:master Dec 28, 2020
@BillyONeal
Copy link
Member

Thanks for your help!

ryukw7 pushed a commit to ryukw7/vcpkg that referenced this pull request Dec 29, 2020
@isanych
[libsodium] use x64 specific gcc options only on x64 platform (micros…
bb75fbf 
…oft#15269)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

@BillyONeal BillyONeal Awaiting requested review from BillyONeal

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libsodium[core]:arm64-linux build failure
3 participants
@isanych @PhoebeHui @BillyONeal