Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mingw] Remove executable extension on non-Windows hosts #15282

Merged
merged 2 commits into from Dec 27, 2020

Conversation

longnguyen2004
Copy link
Contributor

Describe the pull request

@JackBoosY JackBoosY self-assigned this Dec 24, 2020
@JackBoosY JackBoosY added the category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. label Dec 24, 2020
@hectorchu
Copy link

Works perfectly!

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Dec 25, 2020
@longnguyen2004
Copy link
Contributor Author

@hectorchu Please test this one again, I switched to a different mechanism.

@hectorchu
Copy link

The new method works good too!

@BillyONeal BillyONeal merged commit 08c867c into microsoft:master Dec 27, 2020
@BillyONeal
Copy link
Member

The community thanks you :)

@longnguyen2004 longnguyen2004 deleted the mingw-no-exeext branch December 27, 2020 06:43
ryukw7 pushed a commit to ryukw7/vcpkg that referenced this pull request Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MinGW cross-compile from Linux fails because compiler executables don't have .exe extension
4 participants