Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gdal] Update to 3.2.2 #15292

Merged
merged 28 commits into from Apr 19, 2021
Merged

[gdal] Update to 3.2.2 #15292

merged 28 commits into from Apr 19, 2021

Conversation

longhuan2018
Copy link
Contributor

@longhuan2018 longhuan2018 commented Dec 25, 2020 •
edited

update gdal to 3.2.2

@longhuan2018 longhuan2018 changed the title [gdal] Update 3.2.0 [gdal] Update to 3.2.0 Dec 25, 2020
@PhoebeHui PhoebeHui added the category:port-update The issue is with a library, which is requesting update new revision label Dec 25, 2020
@PhoebeHui
Copy link
Contributor

@longhuan2018, thanks for the PR!

Here is CI testing failures, could you please take a look?
gdal with x64-linux and x64-osx:

/bin/sh: 0: Can't open ./config.rpath
configure: error: PROJ 6 symbols not found

failure logs for x64-linux (2).zip

pdal with x64-windows-static:

gdal_d.lib(nc4hdf.c.obj) : error LNK2001: unresolved external symbol H5open
gdal_d.lib(nc4memcb.c.obj) : error LNK2001: unresolved external symbol H5open
gdal_d.lib(hdf5create.c.obj) : error LNK2001: unresolved external symbol H5open
...

failure logs for x64-windows-static.zip

@longhuan2018
Copy link
Contributor Author

I will test under linux before submitting

@PhoebeHui
Copy link
Contributor

@longhuan2018, here latest failure in CI test with gdal:x64-osx:

Undefined symbols for architecture x86_64:
  "_BIO_f_ssl", referenced from:
      _ossl_connect_common in libcurl.a(openssl.c.o)
Undefined symbols for architecture x86_64:
  "_BIO_f_ssl", referenced from:
Undefined symbols for architecture x86_64:
  "_BIO_f_ssl", referenced from:
      _ossl_connect_common in libcurl.a(openssl.c.o)
      _ossl_connect_common in libcurl.a(openssl.c.o)
Undefined symbols for architecture x86_64:
  "_BIO_f_ssl", referenced from:
  "_CFArrayAppendValue", referenced from:
      _ossl_connect_common in libcurl.a(openssl.c.o)
  "_CFArrayAppendValue", referenced from:
  "_CFArrayAppendValue", referenced from:
      _sectransp_connect_common in libcurl.a(sectransp.c.o)
      _append_cert_to_array in libcurl.a(sectransp.c.o)
      _sectransp_connect_common in libcurl.a(sectransp.c.o)
      _append_cert_to_array in libcurl.a(sectransp.c.o)

failure logs for x64-osx (4).zip

@JackBoosY
Copy link
Contributor

Stuck on osx? I will test this PR manually.

@PhoebeHui
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

I can confirm that gdal is stuck in the configuration process in linux, this is the error log content:

  1 configure: WARNING: unrecognized options: --disable-silent-rules
  2 rm: conftest.dSYM: is a directory
  3 rm: conftest.dSYM: is a directory
  4 rm: conftest.dSYM: is a directory
  5 rm: testftrapv.dSYM: is a directory
  6 /bin/sh: ./config.rpath: No such file or directory
  7 ././configure: line 24210: 0: command not found
  8 ././configure: line 24313: 0: command not found

@JackBoosY
Copy link
Contributor

Pinging @longhuan2018 for response. Is work still being done for this PR?

@longhuan2018
Copy link
Contributor Author

Pinging @longhuan2018 for response. Is work still being done for this PR?

I've reproduced the problem in OSX, but I haven't found the reason yet. The Spring Festival is coming soon, and the PR will not continue for the time being

@JackBoosY JackBoosY marked this pull request as draft February 7, 2021 06:58
@longhuan2018 longhuan2018 marked this pull request as ready for review February 20, 2021 09:24
@longhuan2018 longhuan2018 changed the title [gdal] Update to 3.2.0 [gdal] Update to 3.2.1 Feb 20, 2021
@JackBoosY
Copy link
Contributor

Please use command ./vcpkg format-manifest --all then commit changes about vcpkg.json.

@PhoebeHui PhoebeHui mentioned this pull request Feb 24, 2021
Closed
@PhoebeHui PhoebeHui added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Feb 24, 2021
@PhoebeHui
Copy link
Contributor

All features test passed with x64-windows.

@PhoebeHui PhoebeHui removed the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Feb 24, 2021
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Feb 24, 2021
@PhoebeHui PhoebeHui removed the info:reviewed Pull Request changes follow basic guidelines label Apr 1, 2021
@PhoebeHui
Copy link
Contributor

@longhuan2018, could you resolve the conflicts?

@PhoebeHui PhoebeHui mentioned this pull request Apr 1, 2021
Closed
@PhoebeHui PhoebeHui linked an issue Apr 1, 2021 that may be closed by this pull request
[ GDAL ] GDAL Update to 3.2.1 #15476
Closed
@longhuan2018 longhuan2018 changed the title [gdal] Update to 3.2.1 [gdal] Update to 3.2.2 Apr 14, 2021
@JackBoosY
Copy link
Contributor

depends on #17277.

JackBoosY
JackBoosY suggested changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run command vcpkg x-add-version --all then commit the changes.

@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Apr 15, 2021
@JackBoosY
Copy link
Contributor

@strega-nil Since this PR lasts long time, please review and merge this PR first.

@strega-nil strega-nil merged commit 68fc55c into microsoft:master Apr 19, 2021
@JonLiu1993 JonLiu1993 mentioned this pull request Apr 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@PhoebeHui PhoebeHui

@JackBoosY JackBoosY

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ GDAL ] GDAL Update to 3.2.1
4 participants
@longhuan2018 @PhoebeHui @JackBoosY @strega-nil