[libilbc] New port #15331
Merged
[libilbc] New port #15331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geraldcombs
force-pushed
the
add-libilbc
branch
2 times, most recently
from
dc7e1df
to
3d61635
Compare
JackBoosY
added
the
category:new-port
geraldcombs
force-pushed
the
add-libilbc
branch
2 times, most recently
from
d3c3283
to
af0d106
Compare
libilbc is an Internet Low Bit Rate Codec (iLBC) / RFC 3951 codec. Closes microsoft#14836.
geraldcombs
force-pushed
the
add-libilbc
branch
from
af0d106
to
b721afa
Compare
JackBoosY
suggested changes
Dec 29, 2020
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
geraldcombs
force-pushed
the
add-libilbc
branch
2 times, most recently
from
4eacf3e
to
1120f17
Compare
geraldcombs
force-pushed
the
add-libilbc
branch
from
1120f17
to
145ea22
Compare
JackBoosY
approved these changes
Dec 30, 2020
JackBoosY
suggested changes
Dec 30, 2020
There was a problem hiding this comment.
There are some questions:
- libilbc installed
libilbc.pcin PACKAGES/lib/pkgconfig, so we should addvcpkg_fixup_pkgconfigaftervcpkg_install_cmake. - libilbc's docs is installed in PACKAGES/share/doc, the correct path should be PACKAGES/share/libilbc/doc.
- I found the tool is test program, so we shouldn't install it, please add patch or option to disable it.
- In PACKAGES/include/ibc_export.h line 5:
#ifdef ILBC_STATIC_DEFINE
# define ILBC_EXPORT
# define ILBC_NO_EXPORT
#else
# ifndef ILBC_EXPORT
# ifdef ilbc_EXPORTS
/* We are building this library */
# define ILBC_EXPORT __declspec(dllexport)
# else
/* We are using this library */
# define ILBC_EXPORT __declspec(dllimport)
# endif
# endif
# ifndef ILBC_NO_EXPORT
# define ILBC_NO_EXPORT
# endif
#endifThe judgment #ifdef ILBC_STATIC_DEFINE shoud be #if 1 when building static, so please modify this line after build (use vcpkg_replace_string).
geraldcombs
force-pushed
the
add-libilbc
branch
from
18b1680
to
f763c76
Compare
Add vcpkg_fixup_pkgconfig after vcpkg_install_cmake. Install docs into $PREFIX/share/libilbc. Remove ilbc_test after a dynamic build and the bin and debug/bin dirs after a static build. Fixup include/ilbc_export.h for static builds.
geraldcombs
force-pushed
the
add-libilbc
branch
from
f763c76
to
82f96cb
Compare
Done.
libilbc's CMakeLists.txt calls
Done via a patch.
Done. |
JackBoosY
approved these changes
Dec 31, 2020
JackBoosY
added
info:reviewed
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This adds a port for libilbc, an implementation of the Internet Low Bit Rate Codec (iLBC).
What does your PR fix? Fixes [New Port Request] libilbc #14836
Which triplets are supported/not supported?
Tested with x64-osx, but should work with *-windows and *-linux.
Yes.
Yes.