Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raylib update to 3.5.0 #15342

Merged
merged 1 commit into from Dec 30, 2020
Merged

Raylib update to 3.5.0 #15342

merged 1 commit into from Dec 30, 2020

Conversation

JonLiu1993
Copy link
Member

Fix #15318

Update raylib to the latest version 3.5.0

All features are tested successfully in the following triplets:

  • x86-windows
  • x64-windows
  • x64-windows-static

@JonLiu1993 JonLiu1993 added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Dec 28, 2020
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Dec 29, 2020
@NancyLi1013 NancyLi1013 marked this pull request as ready for review December 29, 2020 02:05
@vicroms
Copy link
Member

vicroms commented Dec 30, 2020

Thanks for the PR!

@vicroms vicroms merged commit 9ec6b19 into microsoft:master Dec 30, 2020
@zipzit
Copy link

zipzit commented Jan 27, 2021

Ouch. On Unix box, the directory tree is: .../vcpkg/packages/raylib_x64-linux/include (where all the .h files are located.) Unfortunately, as I peek in the CMakeCache.txt file, everything is pointing at: .../vcpkg/packages/raylib_x64-linux/debug/include...

.../debug/... how did that get in there? The visible error is fatal error: raylib.h: No such file or directory

Am I the only person running Unix boxes via virtualbox on my windows machine for C++ testing?

And I'm not comfortable enough with my CMake skills for a pull request on a fix within the raylib port. Its not clear to me on how this works. Its not clear to me on if the miss is in the intended structure or the directory path variables. At any rate those two things don't match each other.

Any hints as to how to fix this? many thanks.

@JonLiu1993
Copy link
Member Author

Ouch. On Unix box, the directory tree is: .../vcpkg/packages/raylib_x64-linux/include (where all the .h files are located.) Unfortunately, as I peek in the CMakeCache.txt file, everything is pointing at: .../vcpkg/packages/raylib_x64-linux/debug/include...

.../debug/... how did that get in there? The visible error is fatal error: raylib.h: No such file or directory

Am I the only person running Unix boxes via virtualbox on my windows machine for C++ testing?

And I'm not comfortable enough with my CMake skills for a pull request on a fix within the raylib port. Its not clear to me on how this works. Its not clear to me on if the miss is in the intended structure or the directory path variables. At any rate those two things don't match each other.

Any hints as to how to fix this? many thanks.

This PR has been merged, and you re-open a new issue to describe your problem, thank you

@zipzit
Copy link

zipzit commented Jan 27, 2021

Done. Many thanks to the support team here.

@JonLiu1993 JonLiu1993 deleted the dev/Jon/raylib branch February 1, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raylib update to 3.5.0
4 participants