Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build results from 2020-12-27 #15353

Merged
merged 10 commits into from Dec 29, 2020
Merged

Conversation

BillyONeal
Copy link
Member

Build results from 2020-12-27 https://dev.azure.com/vcpkg/public/_build/results?buildId=47034

PASSING, REMOVE FROM FAIL LIST: capnproto:x64-windows (.\scripts\ci.baseline.txt)
PASSING, REMOVE FROM FAIL LIST: capnproto:x64-windows-static (.\scripts\ci.baseline.txt)
PASSING, REMOVE FROM FAIL LIST: capnproto:x86-windows (.\scripts\ci.baseline.txt)

These were fixed by the update to VS2019 version 16.8. Other capnproto skips moved into "supports" because:
capnp.lib(serialize-packed.c++.obj) : error LNK2019: unresolved external symbol __popcnt referenced in function "int __cdecl kj::popCount(unsigned int)" (?popCount@kj@@yahi@Z)
i.e. the port wants popcnt to exist and it doesn't, so this isn't an artifact of our CI.

PASSING, REMOVE FROM FAIL LIST: libepoxy:arm64-windows (.\scripts\ci.baseline.txt)
PASSING, REMOVE FROM FAIL LIST: libsamplerate:arm-uwp (.\scripts\ci.baseline.txt)
PASSING, REMOVE FROM FAIL LIST: libsamplerate:arm64-windows (.\scripts\ci.baseline.txt)
PASSING, REMOVE FROM FAIL LIST: nanogui:arm64-windows (.\scripts\ci.baseline.txt)

Not sure why these got fixed.

REGRESSION: atk:x86-windows. If expected, add atk:x86-windows=fail to .\scripts\ci.baseline.txt
REGRESSION: dcmtk:x86-windows. If expected, add dcmtk:x86-windows=fail to .\scripts\ci.baseline.txt.
REGRESSION: libsigcpp:x86-windows. If expected, add libsigcpp:x86-windows=fail to .\scripts\ci.baseline.txt.

These all had various timeouts and TLS errors connecting ftp.gnome.org; I updated all ports targeting this server to use HTTPs.

REGRESSION: chartdir:x64-osx. If expected, add chartdir:x64-osx=fail to .\scripts\ci.baseline.txt.

Upstream sources broke:

-- Note: chartdir only supports dynamic library linkage. Building dynamic library.
-- Downloading https://www.advsofteng.net/chartdir_cpp_mac.tar.gz...

REGRESSION: leaf:arm-uwp. If expected, add leaf:arm-uwp=fail to .\scripts\ci.baseline.txt.
REGRESSION: leaf:arm64-windows. If expected, add leaf:arm64-windows=fail to .\scripts\ci.baseline.txt.
REGRESSION: leaf:x64-linux. If expected, add leaf:x64-linux=fail to .\scripts\ci.baseline.txt.
REGRESSION: leaf:x64-osx. If expected, add leaf:x64-osx=fail to .\scripts\ci.baseline.txt.
REGRESSION: leaf:x64-uwp. If expected, add leaf:x64-uwp=fail to .\scripts\ci.baseline.txt
REGRESSION: leaf:x64-windows-static. If expected, add leaf:x64-windows-static=fail to .\scripts\ci.baseline.txt.
REGRESSION: leaf:x64-windows. If expected, add leaf:x64-windows=fail to .\scripts\ci.baseline.txt
REGRESSION: leaf:x86-windows. If expected, add leaf:x86-windows=fail to .\scripts\ci.baseline.txt.

Starting package 759/1414: leaf:x86-windows
Building package leaf[core]:x86-windows...
-- Downloading https://github.com/zajo/leaf/archive/0.2.2.tar.gz...
-- Extracting source D:/downloads/zajo-leaf-0.2.2.tar.gz
-- Using source at D:/buildtrees/leaf/src/0.2.2-26417cde9d.clean
-- Configuring x86-windows
-- Building x86-windows-dbg
-- Building x86-windows-rel
-- Installing: D:/packages/leaf_x86-windows/share/leaf/copyright
-- Performing post-build validation
-- Performing post-build validation done
Uploaded binaries to 1 HTTP remotes.
Building package leaf[core]:x86-windows... done
Installing package leaf[core]:x86-windows...
The following files are already installed in D:/installed/x86-windows and are in conflict with leaf:x86-windows

Installed by boost-leaf:x86-windows
    include/boost/leaf/capture.hpp
    include/boost/leaf/common.hpp
    include/boost/leaf/context.hpp
    include/boost/leaf/detail/all.hpp
    include/boost/leaf/detail/demangle.hpp
    include/boost/leaf/detail/function_traits.hpp
    include/boost/leaf/detail/mp11.hpp
    include/boost/leaf/detail/optional.hpp
    include/boost/leaf/detail/print.hpp
    include/boost/leaf/error.hpp
    include/boost/leaf/exception.hpp
    include/boost/leaf/result.hpp

Elapsed time for package leaf:x86-windows: 2.931 s

Caused by the update to Boost 1.75.0. Because this port is touching include/boost, I'm interpreting that as "the author intends users to use it as a Boost library", and have deleted this port in favor of the Boost version.

REGRESSION: magic-get:arm-uwp. If expected, add magic-get:arm-uwp=fail to .\scripts\ci.baseline.txt.
REGRESSION: magic-get:arm64-windows. If expected, add magic-get:arm64-windows=fail to .\scripts\ci.baseline.txt.
REGRESSION: magic-get:x64-linux. If expected, add magic-get:x64-linux=fail to .\scripts\ci.baseline.txt.
REGRESSION: magic-get:x64-osx. If expected, add magic-get:x64-osx=fail to .\scripts\ci.baseline.txt.
REGRESSION: magic-get:x64-uwp. If expected, add magic-get:x64-uwp=fail to .\scripts\ci.baseline.txt.
REGRESSION: magic-get:x64-windows-static. If expected, add magic-get:x64-windows-static=fail to .\scripts\ci.baseline.txt
REGRESSION: magic-get:x64-windows. If expected, add magic-get:x64-windows=fail to .\scripts\ci.baseline.txt.
REGRESSION: magic-get:x86-windows. If expected, add magic-get:x86-windows=fail to .\scripts\ci.baseline.txt.

This library got accepted as boost-pfr. Changing to use the boost port under the same rationale as leaf.

Building package magic-get[core]:x86-windows...
-- Downloading https://github.com/apolukhin/magic_get/archive/abb467c0e22a83bf75a46a9e6610370fabfc39af.tar.gz...
-- Extracting source D:/downloads/apolukhin-magic_get-abb467c0e22a83bf75a46a9e6610370fabfc39af.tar.gz
-- Using source at D:/buildtrees/magic-get/src/0fabfc39af-4ec29c417c.clean
-- Using cached D:/downloads/boost_license_1_0.txt
-- Installing: D:/packages/magic-get_x86-windows/share/magic-get/copyright
-- Performing post-build validation
-- Performing post-build validation done
Uploaded binaries to 1 HTTP remotes.
Building package magic-get[core]:x86-windows... done
Installing package magic-get[core]:x86-windows...
The following files are already installed in D:/installed/x86-windows and are in conflict with magic-get:x86-windows

Installed by boost-pfr:x86-windows
    include/boost/pfr.hpp
    include/boost/pfr/detail/cast_to_layout_compatible.hpp
    include/boost/pfr/detail/config.hpp
    include/boost/pfr/detail/core14_classic.hpp
    include/boost/pfr/detail/core14_loophole.hpp
    include/boost/pfr/detail/core17.hpp
    include/boost/pfr/detail/core17_generated.hpp
    include/boost/pfr/detail/detectors.hpp
    include/boost/pfr/detail/fields_count.hpp
    include/boost/pfr/detail/for_each_field_impl.hpp
    include/boost/pfr/detail/functional.hpp
    include/boost/pfr/detail/io.hpp
    include/boost/pfr/detail/make_flat_tuple_of_references.hpp
    include/boost/pfr/detail/make_integer_sequence.hpp
    include/boost/pfr/detail/offset_based_getter.hpp
    include/boost/pfr/detail/rvalue_t.hpp
    include/boost/pfr/detail/sequence_tuple.hpp
    include/boost/pfr/detail/size_array.hpp
    include/boost/pfr/detail/stdtuple.hpp
    include/boost/pfr/detail/tie_from_structure_tuple.hpp

Elapsed time for package magic-get:x86-windows: 1.472 s

REGRESSION: python3:x64-windows-static. If expected, add python3:x64-windows-static=fail to .\scripts\ci.baseline.txt.
REGRESSION: python3:x64-windows. If expected, add python3:x64-windows=fail to .\scripts\ci.baseline.txt.
REGRESSION: python3:x86-windows. If expected, add python3:x86-windows=fail to .\scripts\ci.baseline.txt.

Probably caused by #14891

     3>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.28.29333\include\cstdint(21,1): error C2061: syntax error: identifier 'std' [D:\buildtrees\python3\x86-windows-rel\v3.9.0-664bf2a259.clean\PCbuild\pythoncore.vcxproj]
     3>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.28.29333\include\cstdint(21,1): error C2059: syntax error: ';' [D:\buildtrees\python3\x86-windows-rel\v3.9.0-664bf2a259.clean\PCbuild\pythoncore.vcxproj]

These files are C++ files getting built as C. mpdecimal.h seems to be the root of it but it has:

#ifdef __cplusplus
  #include <cinttypes>
  #include <climits>
  #include <cstdint>
  #include <cstdio>
  #include <cstdlib>
extern "C" {
#else
  #include <inttypes.h>
  #include <limits.h>
  #include <stdint.h>
  #include <stdio.h>
  #include <stdlib.h>
#endif

so I'm not sure exactly what is up right now....

@Hoikas any ideas?

PASSING, REMOVE FROM FAIL LIST: capnproto:x64-windows (.\scripts\ci.baseline.txt)
PASSING, REMOVE FROM FAIL LIST: capnproto:x64-windows-static (.\scripts\ci.baseline.txt)
PASSING, REMOVE FROM FAIL LIST: capnproto:x86-windows (.\scripts\ci.baseline.txt)

These were fixed by the update to VS2019 version 16.8. Other capnproto skips moved into "supports" because:
capnp.lib(serialize-packed.c++.obj) : error LNK2019: unresolved external symbol __popcnt referenced in function "int __cdecl kj::popCount(unsigned int)" (?popCount@kj@@yahi@Z)
i.e. the port wants popcnt to exist and it doesn't, so this isn't an artifact of our CI.
```
Starting package 759/1414: leaf:x86-windows
Building package leaf[core]:x86-windows...
-- Downloading https://github.com/zajo/leaf/archive/0.2.2.tar.gz...
-- Extracting source D:/downloads/zajo-leaf-0.2.2.tar.gz
-- Using source at D:/buildtrees/leaf/src/0.2.2-26417cde9d.clean
-- Configuring x86-windows
-- Building x86-windows-dbg
-- Building x86-windows-rel
-- Installing: D:/packages/leaf_x86-windows/share/leaf/copyright
-- Performing post-build validation
-- Performing post-build validation done
Uploaded binaries to 1 HTTP remotes.
Building package leaf[core]:x86-windows... done
Installing package leaf[core]:x86-windows...
The following files are already installed in D:/installed/x86-windows and are in conflict with leaf:x86-windows

Installed by boost-leaf:x86-windows
    include/boost/leaf/capture.hpp
    include/boost/leaf/common.hpp
    include/boost/leaf/context.hpp
    include/boost/leaf/detail/all.hpp
    include/boost/leaf/detail/demangle.hpp
    include/boost/leaf/detail/function_traits.hpp
    include/boost/leaf/detail/mp11.hpp
    include/boost/leaf/detail/optional.hpp
    include/boost/leaf/detail/print.hpp
    include/boost/leaf/error.hpp
    include/boost/leaf/exception.hpp
    include/boost/leaf/result.hpp

Elapsed time for package leaf:x86-windows: 2.931 s
```

Caused by the update to Boost 1.75.0. Because this port is touching include/boost, I'm interpreting that as "the author intends users to use it as a Boost library", and have deleted this port in favor of the Boost version.
@BillyONeal BillyONeal added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Dec 28, 2020
@Hoikas
Copy link
Contributor

Hoikas commented Dec 28, 2020

@BillyONeal That's strange. Python 3.9 should build correctly with VS 2015 or higher. I'll fire up a VS 2017 virtual machine and look soon.

@BillyONeal
Copy link
Member Author

@Hoikas to clarify, when I try to build this locally it works fine, it's only broken in CI; I suspect it's some hidden conflict with another port. But I didn't see where /TC is coming from in any of Python's build scripts....

ports/chartdir/portfile.cmake Outdated Show resolved Hide resolved
Version: removed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With versioning, this would need to be 0.2.2#1 to enable graceful constraint transition.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... doesn't that make it a lie though?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vicroms Maybe we want some kind of way to say "this one is replaced with that one" in version-space

Co-authored-by: ras0219 <533828+ras0219@users.noreply.github.com>
@JackBoosY JackBoosY added the category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. label Dec 29, 2020
@JackBoosY
Copy link
Contributor

LGTM.

@BillyONeal BillyONeal merged commit 580da70 into microsoft:master Dec 29, 2020
@BillyONeal BillyONeal deleted the build_fixes branch December 29, 2020 05:20
ryukw7 pushed a commit to ryukw7/vcpkg that referenced this pull request Dec 29, 2020
* [capnproto] Remove from baseline.

PASSING, REMOVE FROM FAIL LIST: capnproto:x64-windows (.\scripts\ci.baseline.txt)
PASSING, REMOVE FROM FAIL LIST: capnproto:x64-windows-static (.\scripts\ci.baseline.txt)
PASSING, REMOVE FROM FAIL LIST: capnproto:x86-windows (.\scripts\ci.baseline.txt)

These were fixed by the update to VS2019 version 16.8. Other capnproto skips moved into "supports" because:
capnp.lib(serialize-packed.c++.obj) : error LNK2019: unresolved external symbol __popcnt referenced in function "int __cdecl kj::popCount(unsigned int)" (?popCount@kj@@yahi@Z)
i.e. the port wants popcnt to exist and it doesn't, so this isn't an artifact of our CI.

* Remove "passing: remove from fail list" entries.

* [atk, atkmm, gdk-pixbuf, glibmm, gtkmm, libsigcpp, libxmlpp, pangomm] Acquire using HTTPS.

* [chardir] Update osx download.

* [leaf] Remove leaf in favor of boost-leaf.

```
Starting package 759/1414: leaf:x86-windows
Building package leaf[core]:x86-windows...
-- Downloading https://github.com/zajo/leaf/archive/0.2.2.tar.gz...
-- Extracting source D:/downloads/zajo-leaf-0.2.2.tar.gz
-- Using source at D:/buildtrees/leaf/src/0.2.2-26417cde9d.clean
-- Configuring x86-windows
-- Building x86-windows-dbg
-- Building x86-windows-rel
-- Installing: D:/packages/leaf_x86-windows/share/leaf/copyright
-- Performing post-build validation
-- Performing post-build validation done
Uploaded binaries to 1 HTTP remotes.
Building package leaf[core]:x86-windows... done
Installing package leaf[core]:x86-windows...
The following files are already installed in D:/installed/x86-windows and are in conflict with leaf:x86-windows

Installed by boost-leaf:x86-windows
    include/boost/leaf/capture.hpp
    include/boost/leaf/common.hpp
    include/boost/leaf/context.hpp
    include/boost/leaf/detail/all.hpp
    include/boost/leaf/detail/demangle.hpp
    include/boost/leaf/detail/function_traits.hpp
    include/boost/leaf/detail/mp11.hpp
    include/boost/leaf/detail/optional.hpp
    include/boost/leaf/detail/print.hpp
    include/boost/leaf/error.hpp
    include/boost/leaf/exception.hpp
    include/boost/leaf/result.hpp

Elapsed time for package leaf:x86-windows: 2.931 s
```

Caused by the update to Boost 1.75.0. Because this port is touching include/boost, I'm interpreting that as "the author intends users to use it as a Boost library", and have deleted this port in favor of the Boost version.

* [magic-get] Remove magic-get in favor of boost-pfr.

* Update ports/chartdir/portfile.cmake

Co-authored-by: ras0219 <533828+ras0219@users.noreply.github.com>

* Restore versions.

* format-manifest

Co-authored-by: ras0219 <533828+ras0219@users.noreply.github.com>
@BillyONeal
Copy link
Member Author

@Hoikas OK I got the python3 regression to repro consistently locally by running CI on my local box overrnight; will keep you posted

@BillyONeal
Copy link
Member Author

@Hoikas Filed: #15377

@Hoikas
Copy link
Contributor

Hoikas commented Dec 29, 2020

Great work! I was at a loss on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants