[vcpkg] Fix unrecognized identifier errors in prbuild and cibuild. #15354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
added
category:port-bug
ras0219
approved these changes
Dec 29, 2020
| @@ -1,6 +0,0 @@ | |||
| Source: tensorflow-common | |||
There was a problem hiding this comment.
The new approach and the older approach both share a problem in that they will not track changes to the shared files in their ABIs.
The correct (abi-tracking) way to handle this situation is to either:
- Duplicate the files into each port directory
- Keep the
tensorflow-commonport, change it to install the shared files into some directory, such asshare/tensorflow-common/..., and refer to those files from the other ports via${CURRENT_INSTALLED_DIR}/share/....
vicroms
approved these changes
Dec 31, 2020
Error: Unrecognized identifer name false. Add to override list in triplet file. tensorflow-common's version numbers are unchanged because there is no effect on any consumers. Error: Unrecognized identifer name ios. Add to override list in triplet file. This is used in the "ashes" port and is recognized by the community triplet x64-ios.
JackBoosY
approved these changes
Jan 4, 2021
JackBoosY
added
the
category:vcpkg-feature
ras0219
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error: Unrecognized identifer name false. Add to override list in triplet file.
tensorflow-common's version numbers are unchanged because there is no effect on any consumers.
Error: Unrecognized identifer name ios. Add to override list in triplet file.
This is used in the "ashes" port and is recognized by the community triplet x64-ios.