Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[monkeys-audio] Update to 5.70 #15359

Merged

Conversation

c72578
Copy link
Contributor

@c72578 c72578 commented Dec 29, 2020

Describe the pull request

  • What does your PR fix? Fixes #

    • Update to current version 5.70
    • Released MAC_SDK files are currently only provided for download for a
      short period of time and replaced frequently by newer versions.
      See: https://monkeysaudio.com/files/
    • Add alternative download URL from Internet Archive
    • The feature tools was tested the following way:
      .\vcpkg.exe install monkeys-audio[tools]:x86-windows
      .\vcpkg.exe install monkeys-audio[tools]:x64-windows
  • Which triplets are supported/not supported? Have you updated the CI baseline?
    !(uwp|osx|linux)

  • Does your PR follow the maintainer guide?
    Yes

@c72578 c72578 force-pushed the 2020-12-29_monkeys-audio_Update_to_5.70 branch from 7ad2987 to 0ba4780 Compare December 29, 2020 05:11
@c72578 c72578 marked this pull request as ready for review December 29, 2020 05:25
@NancyLi1013 NancyLi1013 self-assigned this Dec 29, 2020
@NancyLi1013 NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Dec 29, 2020
Copy link
Contributor

@NancyLi1013 NancyLi1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested the feature tools?

ports/monkeys-audio/portfile.cmake Show resolved Hide resolved
@c72578
Copy link
Contributor Author

c72578 commented Dec 29, 2020

Could you please help confirm if the end of line format for these two patches is LF instead of CRLF?

The original MAC_SDK source files are CRLF:
Source/Projects/VS2019/Console/Console.vcxproj
Source/Projects/VS2019/MACDll/MACDll.vcxproj

However, the previous versions of the two patch files were both LF only in all lines:
fix-project-config.patch
remove-certificate-step.patch

@c72578
Copy link
Contributor Author

c72578 commented Dec 29, 2020

Have you tested the feature tools?

The feature tools was tested the following way:

.\vcpkg.exe install monkeys-audio[tools]:x86-windows
.\vcpkg.exe install monkeys-audio[tools]:x64-windows

The built mac.exe files are working properly:
vcpkg\installed\x86-windows\tools\monkeys-audio\mac.exe
vcpkg\installed\x64-windows\tools\monkeys-audio\mac.exe

Released MAC_SDK files are currently only provided for download for a
short period of time and replaced frequently by newer versions.
See: https://monkeysaudio.com/files/
- Update patches:
  fix-project-config.patch
  remove-certificate-step.patch
- Add alternative download URL from Internet Archive
@c72578 c72578 force-pushed the 2020-12-29_monkeys-audio_Update_to_5.70 branch from 0ba4780 to 6e27354 Compare December 29, 2020 18:39
@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Dec 30, 2020
@NancyLi1013
Copy link
Contributor

LGTM now, thanks for your PR @c72578.

@vicroms vicroms merged commit 5321ed1 into microsoft:master Dec 30, 2020
@vicroms
Copy link
Member

vicroms commented Dec 30, 2020

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants