[boost-build] Fix cflags and c++flags for msvc #15385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhoebeHui
added
category:vcpkg-bug
PhoebeHui
added
category:port-bug
JackBoosY
approved these changes
Dec 30, 2020
|
LGTM. |
vicroms
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15232
B2 applied both cflags and c++flags when build with C++ source, which cause the 2 options are incompatible, related to Upstream issue boostorg/build#690
Currently this issue has been fixed in boost-build, extract the patches from the 2 commits for fixing this issue:
boostorg/build@ab34158
boostorg/build@f558420
Noted that the first commit caused a bunch of c++ options to disappear, so the second commit fixed missing C++ flags args for msvc.