Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IXWebsocket ] Upgraded to 11.0.4 version #15394

Merged
merged 4 commits into from Dec 31, 2020
Merged

[IXWebsocket ] Upgraded to 11.0.4 version #15394

merged 4 commits into from Dec 31, 2020

Conversation

ludekvodicka
Copy link
Contributor

Describe the pull request

  • What does your PR fix? Fixes #

  • Which triplets are supported/not supported? Have you updated the CI baseline?

  • Does your PR follow the maintainer guide?

@ghost
Copy link

ghost commented Dec 30, 2020 •
edited by ghost

CLA assistant check
All CLA requirements met.

@ludekvodicka ludekvodicka mentioned this pull request Dec 30, 2020
Closed
vicroms
vicroms requested changes Dec 30, 2020
View reviewed changes
ports/ixwebsocket/portfile.cmake Outdated Show resolved Hide resolved
@vicroms vicroms added category:port-update The issue is with a library, which is requesting update new revision requires:author-response labels Dec 30, 2020
ludekvodicka and others added 2 commits December 30, 2020 21:55
@ludekvodicka @vicroms
Update ports/ixwebsocket/portfile.cmake
62108b1 
Co-authored-by: Victor Romero <romerosanchezv@gmail.com>
@ludekvodicka
Static library check, fixup targets
01e6e6e
@ludekvodicka
Copy link
Contributor Author

@vicroms Just added two mentioned changes. I hope it's ok.

@PhoebeHui PhoebeHui changed the title Upgraded IXWebsocket to 11.0.4 version [IXWebsocket ] Upgraded to 11.0.4 version Dec 31, 2020
@PhoebeHui PhoebeHui added requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function info:reviewed Pull Request changes follow basic guidelines and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Dec 31, 2020
PhoebeHui
PhoebeHui approved these changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ixwebsocket[core,mbedtls,openssl,ssl]:x64-windows test passed.

@vicroms vicroms merged commit 53983b0 into microsoft:master Dec 31, 2020
@vicroms
Copy link
Member

vicroms commented Dec 31, 2020

Thanks for the PR!

@ludekvodicka
Copy link
Contributor Author

@vicroms Thanks for the guidance and assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicroms vicroms vicroms approved these changes

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ludekvodicka @vicroms @PhoebeHui