Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wangle] Fix dependency issue #15400

Merged
merged 1 commit into from Dec 31, 2020
Merged

Conversation

PhoebeHui
Copy link
Contributor

Fixes #10827

  1. Wangle generates wangle-targets.cmake for debug and release separately, we removed the wangle-targets.cmake file for debug, and use the release revision when use vcpkg_fix_up_targets, that lead to reference release revision for dependency port when using wangle.
  2. Add patch fix_dependency.patch for fixing above issue, also merge the small change from build.patch togather.

Test changes with https://github.com/tarakan012/wangle_test

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Dec 31, 2020
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Dec 31, 2020
@vicroms vicroms merged commit 3012425 into microsoft:master Dec 31, 2020
@vicroms
Copy link
Member

vicroms commented Dec 31, 2020

Thanks Phoebe!

@PhoebeHui PhoebeHui deleted the dev/Phoebe/wangle branch February 7, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wangle] linking wangle
3 participants