Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] Add x64-windows-static-md to pipeline #15411

Merged
merged 10 commits into from Jan 8, 2021
Merged

[vcpkg] Add x64-windows-static-md to pipeline #15411

merged 10 commits into from Jan 8, 2021

Conversation

ankurvdev
Copy link
Contributor

Add x64-windows-static-md to CI Pipeline checks

@ankurvdev ankurvdev changed the title Add x64-windows-static-md to pipeline [vcpkg] Add x64-windows-static-md to pipeline Jan 1, 2021
@ankurvdev ankurvdev mentioned this pull request Jan 1, 2021
Closed
@JackBoosY JackBoosY self-assigned this Jan 4, 2021
@JackBoosY JackBoosY added requires:discussion category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. labels Jan 4, 2021
@JackBoosY JackBoosY added category:infrastructure Pertaining to the CI/Testing infrastrucutre and removed requires:discussion labels Jan 4, 2021
@ankurvdev
Copy link
Contributor Author

@JackBoosY, @BillyONeal

Looks like the ci pipeline run timed out after getting stuck
I'm guessing some transient infrastructure issues

Can someone with enough permissions restart the run or "re-run failed jobs"

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ankurvdev
Copy link
Contributor Author

Looks like the checks all pass :)
Hate to rush , but I'd love to merge this ASAP if there's no concerns/feedback

Have a few other pull requests that relate to x64-windows-static-md that I'd like to queue up after this and also possibly avoid a re-run/merge from other PRs

@JackBoosY
Copy link
Contributor

LGTM, ping for @BillyONeal review this PR.

BillyONeal
BillyONeal reviewed Jan 5, 2021
View reviewed changes
scripts/ci.baseline.txt Outdated Show resolved Hide resolved
@ankurvdev
Copy link
Contributor Author

@BillyONeal, can we get this merged ?

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jan 7, 2021
@BillyONeal
Copy link
Member

@BillyONeal, can we get this merged ?

It LGTM but the current "community reviewer" is @vicroms so I'd like him to look at it.

@JackBoosY JackBoosY requested a review from vicroms January 8, 2021 02:25
@vicroms vicroms merged commit aa83f4b into microsoft:master Jan 8, 2021
@ankurvdev ankurvdev deleted the x64-windows-stastic-md branch January 18, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

@BillyONeal BillyONeal Awaiting requested review from BillyONeal

@vicroms vicroms Awaiting requested review from vicroms

Assignees

@JackBoosY JackBoosY

Labels
category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. category:infrastructure Pertaining to the CI/Testing infrastrucutre info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elevate x64-windows-static-md to be an official triplet
4 participants
@ankurvdev @BillyONeal @JackBoosY @vicroms