Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] fix "CMake script" -> "makefile" for vcpkg_(n)build_make #15419

Merged
merged 1 commit into from Jan 5, 2021

Conversation

tueda
Copy link
Contributor

@tueda tueda commented Jan 2, 2021

This patch replaces "your CMake script" with "your makefile" in the documentation of vcpkg_build_(n)make.md, which is probably copied from vcpkg_build_cmake.md.

I am not sure if such a small document fix would be accepted as a PR; if not, please feel free to squash it with others.

@ghost
Copy link

ghost commented Jan 2, 2021

CLA assistant check
All CLA requirements met.

@PhoebeHui PhoebeHui added the category:documentation To resolve the issue, documentation will need to be updated label Jan 4, 2021
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jan 4, 2021
@vicroms vicroms merged commit 41e5b08 into microsoft:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:documentation To resolve the issue, documentation will need to be updated info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants