Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opencl] Fix dynamic build on linux #15445

Merged
merged 1 commit into from Jan 5, 2021

Conversation

dweckmann
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

the libraries installation paths are wrong for dynamic path. This pr just fix that

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Only linux dynamic build is impacted by this PR

@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Jan 5, 2021
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dweckmann, thanks for the PR!

Could you update the 'Port-Version' to 6 in CONTROL file?

@dweckmann
Copy link
Contributor Author

@dweckmann, thanks for the PR!

Could you update the 'Port-Version' to 6 in CONTROL file?

oups... I always forgot to do this :) It should be good now.

Thanks for review !

@PhoebeHui PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 5, 2021
@vicroms vicroms merged commit ebedac7 into microsoft:master Jan 5, 2021
@dweckmann dweckmann deleted the fix-opencl-dynamic branch January 6, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants