Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update trantor to 1.1.1 #15460

Merged
merged 1 commit into from Jan 11, 2021
Merged

update trantor to 1.1.1 #15460

merged 1 commit into from Jan 11, 2021

Conversation

kkzi
Copy link
Contributor

@kkzi kkzi commented Jan 5, 2021

update trantor to 1.1.1

  • What does your PR fix? Fixes #
    none

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    x64-windows

  • Does your PR follow the maintainer guide?
    yes

Copy link
Contributor

@NancyLi1013 NancyLi1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you rewrite these two files?

@NancyLi1013 NancyLi1013 self-assigned this Jan 5, 2021
@NancyLi1013 NancyLi1013 added category:port-update The issue is with a library, which is requesting update new revision requires:author-response labels Jan 5, 2021
@kkzi
Copy link
Contributor Author

kkzi commented Jan 7, 2021

Why do you rewrite these two files?

update trantor version from 1.1.0 to 1.1.1, the latest released version

@NancyLi1013
Copy link
Contributor

You just need to update the changes instead of rewriting all contents.

For example, you can only update Version field 1.1.0 as 1.1.1 in CONTROL file. Since there are no any changes about other fields.

@kkzi kkzi closed this Jan 8, 2021
@kkzi kkzi reopened this Jan 8, 2021
@kkzi
Copy link
Contributor Author

kkzi commented Jan 8, 2021

You just need to update the changes instead of rewriting all contents.

For example, you can only update Version field 1.1.0 as 1.1.1 in CONTROL file. Since there are no any changes about other fields.

done

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 11, 2021
@NancyLi1013
Copy link
Contributor

LGTM now, thanks for your PR @kkzi.

@vicroms vicroms merged commit 63c518f into microsoft:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants