Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to hidapi-0.10.1 #15485

Merged
merged 7 commits into from Jan 11, 2021
Merged

Update to hidapi-0.10.1 #15485

merged 7 commits into from Jan 11, 2021

Conversation

JoergAtGithub
Copy link
Contributor

This is the latest release from https://github.com/libusb/hidapi

Be-ing
Be-ing reviewed Jan 6, 2021
View reviewed changes
ports/hidapi/portfile.cmake Outdated Show resolved Hide resolved
@JackBoosY JackBoosY added the category:port-update The issue is with a library, which is requesting update new revision label Jan 7, 2021
JonLiu1993
JonLiu1993 reviewed Jan 7, 2021
View reviewed changes
Copy link
Member

@JonLiu1993 JonLiu1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the control file

@JoergAtGithub
Copy link
Contributor Author

@JonLiu1993 This should be ready for merge now!

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response info:reviewed Pull Request changes follow basic guidelines labels Jan 8, 2021
JonLiu1993
JonLiu1993 reviewed Jan 8, 2021
View reviewed changes
ports/hidapi/vcpkg.json Outdated
@@ -1,7 +1,6 @@
{
"name": "hidapi",
"version-string": "2019-08-30",
"port-version": 1,
"version-string": "2020-11-24",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you should modify the date of PR submission, you can refer to here:
For rolling-release ports, we use the date that the commit was accessed by you, formatted as YYYY-MM-DD. Stated another way: if someone had a time machine and went to that date, they would see this commit as the latest master.

For example, given:

The latest commit was made on 2019-04-19
The current version string is 2019-02-14-1
Today's date is 2019-06-01.
Then if you update the source version today, you should give it version 2019-06-01.control-files.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grafik
Because it's not a rolling release, I used the name of the release tag in Git

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was not careful enough

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 11, 2021
@vicroms vicroms merged commit 4974430 into microsoft:master Jan 11, 2021
@vicroms
Copy link
Member

vicroms commented Jan 11, 2021

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Be-ing Be-ing Be-ing left review comments

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JoergAtGithub @vicroms @Be-ing @JonLiu1993 @JackBoosY