[vcpkg baseline][poppler] Fix issue with using libcurl. #15491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we completely solve this issue instead of simply disabling curl? |
JackBoosY
added
category:port-bug
|
Sure. This just seemed like the quickest fix because poppler does not list curl as a dependency. |
Otherwise, ports using old (eg pre-2.8) CMake minimums might fail when they import the package.
Hoikas
force-pushed
the
fix-poppler-baseline
branch
from
0087b5a
to
0454c47
Compare
JackBoosY
approved these changes
Jan 8, 2021
JackBoosY
added
info:reviewed
JackBoosY
changed the title
|
Ping @vicroms for merge this PR. |
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where poppler will attempt to build with libcurl. Libcurl's cmake config file does not properly set its CMake policies so certain
if()calls fail, causing a cascade failure in the poppler. Should fix issue seen in #15200.What does your PR fix?
See above
Which triplets are supported/not supported? Have you updated the CI baseline?
No change
Does your PR follow the maintainer guide?
Yes