Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openimageio] Bump to 2.2.10.0. #15509

Merged
merged 3 commits into from Jan 17, 2021
Merged

[openimageio] Bump to 2.2.10.0. #15509

merged 3 commits into from Jan 17, 2021

Conversation

Hoikas
Copy link
Contributor

@Hoikas Hoikas commented Jan 7, 2021

This fixes #15413. The openimageio used the deprecated FindPythonInterp in the previous version, which was not playing nicely with vcpkg's python3 port. The most recent openimageio is using the new FindPython module, which behaves correctly.

All features have been tested, with some known issues:

The following other issues are known but seem to have existed previously:

  • The field3d feature does not work on Windows because field3d does not properly expose any symbols.
  • On non-MSVC compilers, to use the ffmpeg and pybind11 features together, either dynamic library linkage needs to be used or -fPIC needs to be set in the C/CXX flags.

Any suggestions on those would be appreciated.

@JackBoosY JackBoosY added the category:port-update The issue is with a library, which is requesting update new revision label Jan 8, 2021
@NancyLi1013
Copy link
Contributor

Hi @Hoikas

Thanks for your PR.

This PR should also fix #13750, #13621. Right?

@Hoikas
Copy link
Contributor Author

Hoikas commented Jan 8, 2021

I think so, yes.

@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Jan 15, 2021

Sorry for the delay.

I think the last thing needs to be done is feature testing.
Have you testing these features in this PR?

Edit: Oh, sorry for my above comment. I have noticed that you tested all features. Thanks so much for your efforts.

LGTM now.

@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 added requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Jan 15, 2021
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Jan 15, 2021
@dan-shaw dan-shaw merged commit 8296ef2 into microsoft:master Jan 17, 2021
@Hoikas Hoikas deleted the openimageio branch January 17, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[openimageio:x64-linux] build failure
4 participants