New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openimageio] Bump to 2.2.10.0. #15509
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
added
the
category:port-update
The issue is with a library, which is requesting update new revision
label
Jan 8, 2021
NancyLi1013
approved these changes
Jan 8, 2021
I think so, yes. |
Sorry for the delay. I think the last thing needs to be done is feature testing. Edit: Oh, sorry for my above comment. I have noticed that you tested all features. Thanks so much for your efforts. LGTM now. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
NancyLi1013
added
requires:all-feature-testing
vcpkg install port[all features supported by that port] needs to be demonstrated to function
and removed
requires:all-feature-testing
vcpkg install port[all features supported by that port] needs to be demonstrated to function
labels
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-update
The issue is with a library, which is requesting update new revision
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #15413. The openimageio used the deprecated FindPythonInterp in the previous version, which was not playing nicely with vcpkg's python3 port. The most recent openimageio is using the new FindPython module, which behaves correctly.
All features have been tested, with some known issues:
The following other issues are known but seem to have existed previously:
-fPIC
needs to be set in the C/CXX flags.Any suggestions on those would be appreciated.
What does your PR fix?
Fixes [openimageio:x64-linux] build failure #15413
Which triplets are supported/not supported? Have you updated the CI baseline?
No change.
Does your PR follow the maintainer guide?
Yes