Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdl2] Fix improper replacement of -lSDL2main + remove IGNORE_FLAGS and SYSTEM_LIBRARIES #15540

Merged
merged 4 commits into from Jan 25, 2021
Merged

[sdl2] Fix improper replacement of -lSDL2main + remove IGNORE_FLAGS and SYSTEM_LIBRARIES #15540

merged 4 commits into from Jan 25, 2021

Conversation

longnguyen2004
Copy link
Contributor

Describe the pull request

  • What does your PR fix? Fixes [SDL2] SYSTEM_LIBRARIES missing #14779
    The replacing of -lSDL2 with -lSDL2d incorrectly replaces -lSDL2main with -lSDL2dmain, when it should be -lSDL2maind. This should fix the problem.
  • Which triplets are supported/not supported? Have you updated the CI baseline?
    All mingw triplets
  • Does your PR follow the maintainer guide?
    Yes

Neumann-A
Neumann-A reviewed Jan 9, 2021
View reviewed changes
ports/sdl2/portfile.cmake Outdated Show resolved Hide resolved
@longnguyen2004 longnguyen2004 changed the title [sdl2] Fix improper replacement of -lSDL2main + add extra IGNORE_FLAGS and SYSTEM_LIBRARIES [sdl2] Fix improper replacement of -lSDL2main + remove IGNORE_FLAGS and SYSTEM_LIBRARIES Jan 10, 2021
@JackBoosY JackBoosY self-assigned this Jan 11, 2021
@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Jan 11, 2021
@longnguyen2004
Copy link
Contributor Author

Bumping this for review.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jan 18, 2021
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed info:reviewed Pull Request changes follow basic guidelines labels Jan 22, 2021
@dan-shaw dan-shaw merged commit 124f5d9 into microsoft:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neumann-A Neumann-A Neumann-A left review comments

@JackBoosY JackBoosY JackBoosY approved these changes

@dan-shaw dan-shaw dan-shaw approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SDL2] SYSTEM_LIBRARIES missing
4 participants
@longnguyen2004 @Neumann-A @JackBoosY @dan-shaw