Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg,boost-modular-build-helper] initial ppc64le community support #15572

Merged
merged 7 commits into from Jan 22, 2021

Conversation

lebdron
Copy link
Contributor

@lebdron lebdron commented Jan 11, 2021

Add ppc64le-linux triplet, and required changes in vcpkg and boost-modular-build-helper
Tested with qemu

@PhoebeHui PhoebeHui added category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed requires:discussion labels Jan 12, 2021
@PhoebeHui
Copy link
Contributor

@lebdron, could you resolve the conflicts?

Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
@lebdron
Copy link
Contributor Author

lebdron commented Jan 15, 2021

@PhoebeHui done!

@PhoebeHui
Copy link
Contributor

@lebdron, thanks for your updates! We need additional steps to fix the CI failures, we added new CI check features to vcpkg, see PR#15655.

  1. Merge from master
  2. vcpkg x-add-version boost-modular-build-helper

I have committed the changes to this PR.

@lebdron
Copy link
Contributor Author

lebdron commented Jan 20, 2021

@PhoebeHui @dan-shaw could you take a look again please? Checks are passing

Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @dan-shaw, could you help further review?

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jan 20, 2021
@dan-shaw dan-shaw merged commit 83b8e27 into microsoft:master Jan 22, 2021
@lebdron lebdron deleted the ppc64le-support branch January 22, 2021 23:50
strega-nil added a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
…icrosoft#15572)

* [vcpkg] initial ppc64le community support

Signed-off-by: Andrei Lebedev <lebdron@gmail.com>

* [boost-modular-build-helper] ppc64le support

Signed-off-by: Andrei Lebedev <lebdron@gmail.com>

* Merge from master

Co-authored-by: PhoebeHui <20694052+PhoebeHui@users.noreply.github.com>
Co-authored-by: dan-shaw <51385773+dan-shaw@users.noreply.github.com>
Co-authored-by: Nicole Mazzuca <mazzucan@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants