New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] Add a different way to use CommandBuilder, support InWorkingDirectory #15583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strega-nil
force-pushed
the
commands-builder
branch
from
January 11, 2021 18:20
93095a1
to
7a1eaec
Compare
* CmdLineBuilder - add rvalue overloads * Add InWorkingDirectory support
strega-nil
force-pushed
the
commands-builder
branch
from
January 11, 2021 18:47
7a1eaec
to
d6983a4
Compare
BillyONeal
reviewed
Jan 11, 2021
ras0219
reviewed
Jan 11, 2021
BillyONeal
reviewed
Jan 11, 2021
BillyONeal
reviewed
Jan 11, 2021
BillyONeal
approved these changes
Jan 11, 2021
Co-authored-by: Billy O'Neal <bion@microsoft.com>
JackBoosY
added
category:vcpkg-feature
The issue is a new capability of the tool that doesn’t already exist and we haven’t committed
info:internal
This PR or Issue was filed by the vcpkg team.
labels
Jan 12, 2021
ras0219
approved these changes
Jan 12, 2021
strega-nil
added a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
…irectory (microsoft#15583) * [vcpkg] Add stuff to the system.process API * CmdLineBuilder - add rvalue overloads * Add InWorkingDirectory support * remove `&&` outside of system.process.cpp * minor CR * move the non-InWorkingDirectory functions into the header as inline * Update toolsrc/include/vcpkg/base/system.process.h Co-authored-by: Billy O'Neal <bion@microsoft.com> * fix CmdLineBuilder name * moar bugfixin * fix native() location Co-authored-by: Billy O'Neal <bion@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:vcpkg-feature
The issue is a new capability of the tool that doesn’t already exist and we haven’t committed
info:internal
This PR or Issue was filed by the vcpkg team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out of #15054