Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] Add a different way to use CommandBuilder, support InWorkingDirectory #15583

Merged
merged 8 commits into from Jan 12, 2021

Conversation

strega-nil
Copy link
Contributor

Pulled out of #15054

* CmdLineBuilder - add rvalue overloads
* Add InWorkingDirectory support
toolsrc/include/vcpkg/base/system.process.h Outdated Show resolved Hide resolved
toolsrc/src/vcpkg/base/system.process.cpp Outdated Show resolved Hide resolved
toolsrc/src/vcpkg/base/system.process.cpp Outdated Show resolved Hide resolved
strega-nil and others added 2 commits January 11, 2021 15:14
@JackBoosY JackBoosY self-assigned this Jan 12, 2021
@JackBoosY JackBoosY added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team. labels Jan 12, 2021
toolsrc/src/vcpkg/base/system.process.cpp Outdated Show resolved Hide resolved
@strega-nil strega-nil merged commit 94b9db9 into microsoft:master Jan 12, 2021
@strega-nil strega-nil deleted the commands-builder branch January 19, 2021 19:51
strega-nil added a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
…irectory (microsoft#15583)

* [vcpkg] Add stuff to the system.process API

* CmdLineBuilder - add rvalue overloads
* Add InWorkingDirectory support

* remove `&&` outside of system.process.cpp

* minor CR

* move the non-InWorkingDirectory functions into the header as inline

* Update toolsrc/include/vcpkg/base/system.process.h

Co-authored-by: Billy O'Neal <bion@microsoft.com>

* fix CmdLineBuilder name

* moar bugfixin

* fix native() location

Co-authored-by: Billy O'Neal <bion@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants