Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[speexdsp] Configure and install speexdsp.pc #15585

Merged
merged 2 commits into from Jan 13, 2021
Merged

[speexdsp] Configure and install speexdsp.pc #15585

merged 2 commits into from Jan 13, 2021

Conversation

adam-bloom
Copy link
Contributor

@adam-bloom adam-bloom commented Jan 12, 2021 •
edited

Describe the pull request

  • What does your PR fix?
    The speexdsp port did not previously configure and support pkgconfig.

@ghost
Copy link

ghost commented Jan 12, 2021 •
edited by ghost

CLA assistant check
All CLA requirements met.

@adam-bloom adam-bloom marked this pull request as ready for review January 12, 2021 03:02
@adam-bloom adam-bloom mentioned this pull request Jan 12, 2021
Merged
@JackBoosY JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jan 12, 2021
NancyLi1013
NancyLi1013 suggested changes Jan 12, 2021
View reviewed changes
ports/speexdsp/CONTROL Outdated Show resolved Hide resolved
@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 13, 2021
@NancyLi1013
Copy link
Contributor

LGTM now, thanks for your PR @adam-bloom.

@dan-shaw dan-shaw merged commit a5b371b into microsoft:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adam-bloom @NancyLi1013 @JackBoosY @dan-shaw