[libzip] Relative pkgconfig paths #15589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-bloom
force-pushed
the
libzip_pkgconfig
branch
from
75feeb6
to
0745f0b
Compare
JackBoosY
added
the
category:port-feature
JackBoosY
approved these changes
Jan 12, 2021
|
LGTM. |
|
Note this PR doesn't fix issue #2973, this just fix the pkgconfig part. |
|
@JackBoosY sorry for my brevity, but I think you figured out what I meant: this is the last item remaining as a part of that issue and it can be closed. I did not mean to suggest that it fixed most of that issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
libzip.pc currently builds with absolute paths. This adds the missing call to
vcpkg_fixup_pkgconfig.