Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[physfs] Enable arm64 for non-Windows targets #15637

Merged
merged 3 commits into from Jan 15, 2021
Merged

[physfs] Enable arm64 for non-Windows targets #15637

merged 3 commits into from Jan 15, 2021

Conversation

past-due
Copy link
Contributor

Describe the pull request

Enable physfs port on ARM64 (for non-Windows builds)

  • Which triplets are supported/not supported? Have you updated the CI baseline?

CI baseline update not needed - this simply makes the port's supports field more precise (since it was added in #10781)

@NancyLi1013 NancyLi1013 self-assigned this Jan 14, 2021
@NancyLi1013 NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jan 14, 2021
@NancyLi1013
Copy link
Contributor

Hi @past-due

Thanks for your PR.

Have you tested arm64-linux or arm64-osx on your local? Since these triplets are community triplets. Our CI machine will not test these triplets.

@past-due past-due marked this pull request as draft January 14, 2021 14:23
@past-due past-due marked this pull request as ready for review January 14, 2021 14:40
@past-due
Copy link
Contributor Author

Have you tested arm64-linux or arm64-osx on your local? Since these triplets are community triplets. Our CI machine will not test these triplets.

@NancyLi1013:

  • I have tested on arm64-osx and it builds without issues.
  • I frequently build physfs (albeit not through vcpkg) for arm64 on Linux without issues. Based on the simplicity of the port's portfile.cmake, I don't see anything that would interfere with physfs building on arm64-linux via vcpkg.

@past-due past-due changed the title [physfs] Enable arm64 on non-Windows builds [physfs] Enable arm64 for non-Windows targets Jan 14, 2021
@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 15, 2021
@NancyLi1013
Copy link
Contributor

LGTM now, thanks for your PR @past-due.

@vicroms vicroms merged commit 0e46f93 into microsoft:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicroms vicroms vicroms approved these changes

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@past-due @NancyLi1013 @vicroms