Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libssh] Add support for Android #15687

Merged
merged 66 commits into from Jan 25, 2021
Merged

[libssh] Add support for Android #15687

merged 66 commits into from Jan 25, 2021

Conversation

ahmedyarub
Copy link
Contributor

Describe the pull request
Allows using VCPKG toolchain + Android toolchain. Otherwise, we would not be able to use Android toolchain together with VCPKG building libssh. After this, SDK building should work on VCPKG.
This change can be easily extended to enable building with VCPKG + iOS/Wasm or any other cross-platform build.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@JackBoosY JackBoosY added category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. category:port-bug The issue is with a library, which is something the port should already support labels Jan 18, 2021
NancyLi1013
NancyLi1013 suggested changes Jan 18, 2021
View reviewed changes
port_versions/baseline.json Outdated Show resolved Hide resolved
port_versions/l-/libssh.json Outdated Show resolved Hide resolved
ports/libssh/portfile.cmake Outdated Show resolved Hide resolved
JackBoosY and others added 4 commits January 17, 2021 21:46
update baseline
eeda15a
@NancyLi1013
Update ports/libssh/portfile.cmake
078bfa5 
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@NancyLi1013
Update port_versions/l-/libssh.json
f125516 
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@NancyLi1013
Update port_versions/baseline.json
eb0d6f7 
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@ahmedyarub
Copy link
Contributor Author

Requested changes made

NancyLi1013
NancyLi1013 suggested changes Jan 18, 2021
View reviewed changes
ports/libssh/CONTROL Outdated Show resolved Hide resolved
@ahmedyarub
Copy link
Contributor Author

@NancyLi1013 still waiting for my response?

@NancyLi1013
Copy link
Contributor

x86-windows still failed. I will check this later.

@NancyLi1013
Copy link
Contributor

For the files in port_versions folder, it would be better to update via vcpkg x-add-version libssh instead of updating them manually.

@ahmedyarub
Copy link
Contributor Author

vcpkg x-add-version libssh

What about now?

@ahmedyarub
Copy link
Contributor Author

I can't understand why these tests are failing. They are not related at all to my changes.

@NancyLi1013
Copy link
Contributor

I can't understand why these tests are failing. They are not related at all to my changes.

The failures are caused by our CI test environment. Now All checks have passed after rerun failed job.

@ahmedyarub
Copy link
Contributor Author

I can't understand why these tests are failing. They are not related at all to my changes.

The failures are caused by our CI test environment. Now All checks have passed after rerun failed job.

So can it be merged?

@dan-shaw dan-shaw merged commit b7c8a30 into microsoft:master Jan 25, 2021
@ahmedyarub ahmedyarub deleted the libssh_android branch January 29, 2021 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-shaw dan-shaw dan-shaw left review comments

@ahmedalnuaimi ahmedalnuaimi ahmedalnuaimi left review comments

@ras0219 ras0219 ras0219 requested changes

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

@ras0219-msft ras0219-msft Awaiting requested review from ras0219-msft

Assignees

@NancyLi1013 NancyLi1013

Labels
category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@ahmedyarub @NancyLi1013 @ras0219-msft @ahmedalnuaimi @ras0219 @dan-shaw @JackBoosY @strega-nil