Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cppgraphqlgen] Update to 3.5.0 release #15701

Merged
merged 5 commits into from Jan 20, 2021

Conversation

wravery
Copy link
Contributor

@wravery wravery commented Jan 16, 2021

Describe the pull request

  • What does your PR fix?

Update cppgraphqlgen to the 3.5.0 release and replace the deprecated vcpkg_copy_tool_dependencies CMake function with vcpkg_copy_tools.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

This PR depends on #15700 (or installing pegtl with --head). Otherwise it should be supported on all of the same triplets as the CI baseline. I updated the baseline versions with x-add-version.

Yes.

@wravery
Copy link
Contributor Author

wravery commented Jan 16, 2021

The checks won't pass for this PR until #15700 is merged.

@JackBoosY JackBoosY self-assigned this Jan 18, 2021
@JackBoosY JackBoosY added category:port-update The issue is with a library, which is requesting update new revision depends:different-pr This PR or Issue depends on a PR which has been filed labels Jan 18, 2021
@wravery wravery marked this pull request as ready for review January 19, 2021 18:04
@wravery
Copy link
Contributor Author

wravery commented Jan 19, 2021

I just rebased and force pushed to clean up the diff/commit log. This should be identical to the previous version which already passed the CI checks, so leaving it marked as ready.

@ras0219-msft
Copy link
Contributor

Thanks once again for the update!

With our new versioning feature, we now support better intelligence about the versioning schemes used by projects. I've reformatted the cppgraphqlgen manifest over to vcpkg.json in order to utilize version-semver.

LGTM to merge once the CI passes again :)

@JackBoosY JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Jan 20, 2021
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jan 20, 2021
@ras0219-msft ras0219-msft merged commit 45fc558 into microsoft:master Jan 20, 2021
@wravery wravery deleted the cppgraphqlgen branch January 20, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants