[nsync] create a new port #15714
Merged
[nsync] create a new port #15714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
added
the
category:new-port
NancyLi1013
suggested changes
Jan 18, 2021
NancyLi1013
suggested changes
Jan 18, 2021
NancyLi1013
reviewed
Jan 27, 2021
* update version SHA
NancyLi1013
approved these changes
Jan 27, 2021
NancyLi1013
added
info:reviewed
|
LGTM now, thanks for your PR @luncliff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
This is a rework of #7614
Triplet support
The library's CMakeLists checks
Windows,Darwin,Linux,FreeBSD, etc. And it seems there is no hack for each platform.Currently working on Windows. Failure in the other platforms will be fixed in the next commits.
For Windows,
__declspec(dllexport)in the source code. IMO it intends to beSTATIC.Does your PR follow the maintainer guide?
Yes. Wish for any kind of feedback :)