Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sfml] Install usage and change version scheme to relaxed #15718

Merged
merged 1 commit into from Jan 20, 2021

Conversation

ras0219
Copy link
Contributor

@ras0219 ras0219 commented Jan 17, 2021

See title. The SFML usage file was not being deployed.

@JackBoosY JackBoosY self-assigned this Jan 18, 2021
@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jan 18, 2021
@JackBoosY
Copy link
Contributor

Current:

The package sfml:x86-windows provides CMake targets:

    find_package(SFML CONFIG REQUIRED)
    # Note: 7 target(s) were omitted.
    target_link_libraries(main PRIVATE FLAC OpenAL OpenGL Vorbis)

usage:

The package sfml provides CMake targets:

    find_package(SFML COMPONENTS system window graphics CONFIG REQUIRED)
    # Windows
    target_link_libraries(main PRIVATE FLAC OpenAL OpenGL Vorbis)
    # Linux/MacOS
    target_link_libraries(main PRIVATE X11 FLAC UDev OpenAL)

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jan 18, 2021
@Neumann-A
Copy link
Contributor

that still looks wrong because the target_link_libraries call is not displaying sfml targets.

@JackBoosY JackBoosY added requires:discussion and removed info:reviewed Pull Request changes follow basic guidelines labels Jan 19, 2021
@ras0219
Copy link
Contributor Author

ras0219 commented Jan 19, 2021

New text is:

The package sfml provides CMake targets:

    find_package(SFML COMPONENTS system window graphics CONFIG REQUIRED)
    target_link_libraries(main PRIVATE sfml-system sfml-network sfml-graphics sfml-window)

    # If you want SFML to provide an implementation of main():
    target_link_libraries(main PRIVATE sfml-main)

@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:discussion labels Jan 20, 2021
@dan-shaw dan-shaw merged commit 93db9ac into microsoft:master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants