Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libgeotiff] Fix packagename via find_package #15750

Merged
merged 14 commits into from
Jan 29, 2021
Merged

[libgeotiff] Fix packagename via find_package #15750

merged 14 commits into from
Jan 29, 2021

Conversation

NancyLi1013
Copy link
Contributor

Describe the pull request

Update cmake config files name to fix the usage since they are named by PROJECT_NAME.

CMake Error at /home/max/code/vcpkg/scripts/buildsystems/vcpkg.cmake:644 (_find_package):
  Could not find a configuration file for package "geoTIFF" that is
  compatible with requested version "".

  The following configuration files were considered but not accepted:

    /home/max/code/vcpkg/installed/x64-linux/share/GeoTIFF/geotiff-config.cmake, version: 1.6.0

Now it has been updated as the follows:

find_package(GeoTIFF CONFIG REQUIRED)

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jan 19, 2021
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jan 27, 2021
@JackBoosY JackBoosY linked an issue Jan 28, 2021 that may be closed by this pull request
[libLAS] improve suggested cmake targets #15908
Closed
@dan-shaw dan-shaw merged commit 82a9a84 into microsoft:master Jan 29, 2021
@dg0yt
Copy link
Contributor

dg0yt commented Nov 8, 2021 •
edited
Loading

Oh! Weren't liblas and pdal indication enough that canonical usage is

find_package(GeoTIFF)

This PR and the referenced issue are invalid. I'm working on a port update, and I will need to revert this change.

@dg0yt dg0yt mentioned this pull request Nov 8, 2021
Open
dg0yt added a commit to dg0yt/vcpkg that referenced this pull request Nov 8, 2021
@dg0yt
Restore GeoTIFF cmake package name (reverts microsoft#15750)
0c5617e
dan-shaw pushed a commit that referenced this pull request Nov 10, 2021
@dg0yt
[libgeotiff] Update to 1.7.0, revise features and config (#21253)
369878e 
* Update to 1.7.0

* Refresh patches, drop fix-proj4.patch

* Restore GeoTIFF cmake package name (reverts #15750)

* Add usage (reason: #15723)

* Remove zlib dependency, transitive usage only

* Move tools to optional feature

* Modernize portfile, fix copyright

* Don't install doc and man files

* Trim main patch

* Allow reduced tiff dependencies

* Update versions

* Remove libgeotiff uwp failure from CI baseline

* Update GeoTIFF in gdal wrapper

* Update versions

* Update GeoTIFF in pdal config

* Update versions

* Switch to 'version' field

* Update versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[libLAS] improve suggested cmake targets [libgeotiff] find_package(geotiff) does not work on Linux
4 participants
@NancyLi1013 @dg0yt @JackBoosY @dan-shaw