Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openvdb] Fix vcpkg-cmake-wrapper #15902

Merged
merged 2 commits into from
Jan 28, 2021
Merged

[openvdb] Fix vcpkg-cmake-wrapper #15902

merged 2 commits into from
Jan 28, 2021

Conversation

JackBoosY
Copy link
Contributor

Add option OPENVDB_USE_STATIC_LIBS to cmake wrapper since FindOpenVDB.cmake use that.

Fixes #15901.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jan 27, 2021
@JackBoosY
Copy link
Contributor Author

@Fedr Can you please test this PR?

Thanks.

Fedr
Fedr approved these changes Jan 27, 2021
View reviewed changes
Copy link

@Fedr Fedr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for a prompt fix, this solves my issue!

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jan 28, 2021
@dan-shaw dan-shaw merged commit 2928667 into microsoft:master Jan 28, 2021
@JackBoosY JackBoosY deleted the dev/jack/15901 branch January 28, 2021 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fedr Fedr Fedr approved these changes

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

openvdb: cmake get_prerequisites error
4 participants
@JackBoosY @Fedr @NancyLi1013 @dan-shaw