Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[raylib] Fix usage #15935

Merged
merged 5 commits into from
Feb 2, 2021
Merged

Conversation

NancyLi1013
Copy link
Contributor

Describe the pull request

Currently, raylib-config.cmake is broken.
So revert to use vcpkg-cmake-wrapper.cmake to fix the usage.

Upstream has planned to export targets https://github.com/raysan5/raylib/blob/master/cmake/InstallConfigurations.cmake, but there are still other work needed to be done. We can remove vcpkg-cmake-wrapper.cmake once the new release supports cmake targets. raysan5/raylib#1523

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jan 29, 2021
ports/raylib/CONTROL Outdated Show resolved Hide resolved
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Feb 1, 2021
@ras0219-msft ras0219-msft merged commit d4ba955 into microsoft:master Feb 2, 2021
@ras0219-msft
Copy link
Contributor

LGTM, we should plan to remove this in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[raylib] build failure
3 participants