[libarchive] Fix static linking dependencies #16082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NancyLi1013
added
the
category:port-bug
NancyLi1013
suggested changes
Feb 7, 2021
There was a problem hiding this comment.
Please also bump Port-Version in CONTROL file.
Also use the command vcpkg x-add-version libarchive to update the files in versions folder.
https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/maintainer-guide.md#update-the-version-files-in-versions-of-any-modified-ports
DDoSolitary
force-pushed
the
patch-libarchive-dep
branch
from
3ec45c0
to
9199e69
Compare
|
Sorry I forgot to commit the updated CONTROL file when running |
DDoSolitary
force-pushed
the
patch-libarchive-dep
branch
from
9199e69
to
3a7179b
Compare
|
I have to idea why the x64_linux CI tests failed. |
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The failures on x64-linux are not related with this PR. I have rerun to rebuild. |
NancyLi1013
approved these changes
Feb 8, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I'm unable to reproduce the x64-linux error locally. Running The errors in windows triplets seems irrelevant. They failed due to some network errors. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
It's quite surprising that it's trying to link against glib. The cmake port doesn't depend on the glib port at all (not even intermediately, glib is not installed when I built cmake in a clean vcpkg installation). I guess the reason why I'm unable to reproduce the error is that my Arch Linux environment already has the library available under |
|
cc @ras0219 @ras0219-msft Thanks. |
|
Strangely, after removing libglib-2.0.so from /usr/lib, build fails with another error So I still have no idea why it's unable to find the glib library in the CI build... |
PhoebeHui
added
the
depends:different-pr
|
Could you please resolve the conflicts? |
NancyLi1013
removed
the
depends:different-pr
DDoSolitary
force-pushed
the
patch-libarchive-dep
branch
from
3a7179b
to
81e04fe
Compare
|
@NancyLi1013 Rebased. |
NancyLi1013
approved these changes
Apr 9, 2021
|
LGTM now, thanks for your patience @DDoSolitary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix configuration of libarchive's dependencies zstd and zlib, which would otherwise cause undefined symbols error when linking statically.